From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <f.ebner@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 64CBC766DB for <pve-devel@lists.proxmox.com>; Tue, 19 Oct 2021 09:55:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4880129ADA for <pve-devel@lists.proxmox.com>; Tue, 19 Oct 2021 09:55:15 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7C7822990B for <pve-devel@lists.proxmox.com>; Tue, 19 Oct 2021 09:55:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EE19E468C1 for <pve-devel@lists.proxmox.com>; Tue, 19 Oct 2021 09:55:03 +0200 (CEST) From: Fabian Ebner <f.ebner@proxmox.com> To: pve-devel@lists.proxmox.com Date: Tue, 19 Oct 2021 09:54:52 +0200 Message-Id: <20211019075459.14328-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211019075459.14328-1-f.ebner@proxmox.com> References: <20211019075459.14328-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.267 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SHORT 0.001 Use of a URL Shortener for very short URL SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH storage 3/3] bump APIVER and APIAGE X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 19 Oct 2021 07:55:15 -0000 Added blockers parameter to volume_rollback_is_possible. Replaced volume_snapshot_list with volume_snapshot_info. Signed-off-by: Fabian Ebner <f.ebner@proxmox.com> --- ApiChangeLog | 16 ++++++++++++++++ PVE/Storage.pm | 4 ++-- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/ApiChangeLog b/ApiChangeLog index 8c119c5..4094ca2 100644 --- a/ApiChangeLog +++ b/ApiChangeLog @@ -6,6 +6,21 @@ without breaking anything unaware of it.) Future changes should be documented in here. +## Version 10: + +* Replace `volume_snapshot_list` with `volume_snapshot_info`: + + `volume_snapshot_list` was used exclusively by replication and currently, replication is only + allowed for the storage type `zfspool`. Thus, no external plugins should be affected by this + change and `APIAGE` is *not* reset. + + `volume_snapshot_info` returns a hash with snapshot names as keys and `id` and `timestamp` data + for each snapshot, rather than just an array of snaphsot names like `volume_snapshot_list` did. + +* Add `blockers` parameter to `volume_rollback_is_possible`: + + The parameter *can* be used to return a list of snapshots that is currently preventing rollback. + ## Version 9: (AGE resets to 0): * volume_import_formats gets a new parameter *inserted*: @@ -23,3 +38,4 @@ Future changes should be documented in here. * $with_snapshots *may* now be an array reference containing an ordered list of snapshots, but *may* also just be a boolean, and the contained list *may* be ignored, so it can still be treated as a boolean. + diff --git a/PVE/Storage.pm b/PVE/Storage.pm index 5d389be..bc477c1 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -41,11 +41,11 @@ use PVE::Storage::PBSPlugin; use PVE::Storage::BTRFSPlugin; # Storage API version. Increment it on changes in storage API interface. -use constant APIVER => 9; +use constant APIVER => 10; # Age is the number of versions we're backward compatible with. # This is like having 'current=APIVER' and age='APIAGE' in libtool, # see https://www.gnu.org/software/libtool/manual/html_node/Libtool-versioning.html -use constant APIAGE => 0; +use constant APIAGE => 1; # load standard plugins PVE::Storage::DirPlugin->register(); -- 2.30.2