From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <f.ebner@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 325DC7667E for <pve-devel@lists.proxmox.com>; Tue, 19 Oct 2021 09:55:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 29F7429932 for <pve-devel@lists.proxmox.com>; Tue, 19 Oct 2021 09:55:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 28B8E298D2 for <pve-devel@lists.proxmox.com>; Tue, 19 Oct 2021 09:55:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D8C1E468E1 for <pve-devel@lists.proxmox.com>; Tue, 19 Oct 2021 09:55:03 +0200 (CEST) From: Fabian Ebner <f.ebner@proxmox.com> To: pve-devel@lists.proxmox.com Date: Tue, 19 Oct 2021 09:54:49 +0200 Message-Id: <20211019075459.14328-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.270 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH-SERIES storage/guest-common/manager] Follow-up for fixing replication/rollback interaction X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 19 Oct 2021 07:55:41 -0000 Returning more information about snapshots allows for better decisions when picking the incremental base snapshot. Namely, to distinguish between different snapshots with the same name, and to choose a more recent snapshot in some cases, reducing the send delta. On top of that, the code in find_common_replication_snapshot becomes simpler. Mostly as discussed off-list with Fabian G., but instead of just changing the return type of volume_snapshot_list, it has been replaced with a new function. I felt like that would allow for a cleaner break and the old name was not fully accurate anymore. Applies on top of the original series: https://lists.proxmox.com/pipermail/pve-devel/2021-August/049699.html Dependencies/breaks: 1. pve-guest-common (except patch #1) depends on pve-storage patch #1. 2. pve-storage patch #2 breaks old pve-guest-common. 3. pve-guest-common patch #2 build-breaks old pve-manager. 4. pve-manager patch #3 build-depends on pve-guest-common patch #2. pve-storage: Fabian Ebner (3): plugin: add volume_snapshot_info function plugin: remove volume_snapshot_list bump APIVER and APIAGE ApiChangeLog | 16 ++++++++++++++++ PVE/Storage.pm | 21 +++++++-------------- PVE/Storage/Plugin.pm | 11 ++++++----- PVE/Storage/ZFSPlugin.pm | 6 ------ PVE/Storage/ZFSPoolPlugin.pm | 23 ++++++++++++++++++----- 5 files changed, 47 insertions(+), 30 deletions(-) pve-guest-common: Fabian Ebner (4): replication: refactor finding most recent common replication snapshot replication: prepare: return additional information about snapshots replication: find common snapshot: use additional information config: snapshot delete check: use volume_snapshot_info src/PVE/AbstractConfig.pm | 4 +-- src/PVE/Replication.pm | 73 ++++++++++++++++++--------------------- 2 files changed, 36 insertions(+), 41 deletions(-) pve-manager: Fabian Ebner (3): test: replication: avoid implicit return for volume_snapshot test: replication: mock volume_snapshot_info test: replication: remove mocking for obsolete volume_snapshot_list test/ReplicationTestEnv.pm | 40 +++++++++++++++++++++++--------------- 1 file changed, 24 insertions(+), 16 deletions(-) -- 2.30.2