From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <d.csapak@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A84D175C97 for <pbs-devel@lists.proxmox.com>; Fri, 15 Oct 2021 10:07:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9AC5B259A5 for <pbs-devel@lists.proxmox.com>; Fri, 15 Oct 2021 10:07:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2D20225991 for <pbs-devel@lists.proxmox.com>; Fri, 15 Oct 2021 10:07:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id F13D046553 for <pbs-devel@lists.proxmox.com>; Fri, 15 Oct 2021 10:07:32 +0200 (CEST) From: Dominik Csapak <d.csapak@proxmox.com> To: pbs-devel@lists.proxmox.com Date: Fri, 15 Oct 2021 10:07:28 +0200 Message-Id: <20211015080730.1427860-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.296 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [RFC PATCH widget-toolkit/backup] percent encode the task status line X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 15 Oct 2021 08:07:33 -0000 to avoid having a newline (and other control characters) in the task status, percent-encode the last line decoding happens in the web ui alternatively, it would make sense to decode it again in the backend directly, since only the writing into the logfile is problematic. this would make the api a bit nicer, since an api user would not have to do this themselves. on the other hand, not having control characters in the api result makes it a bit safer i suppose... proxmox-widget-toolkit: Dominik Csapak (1): Utils: percent-decode the task status src/Utils.js | 12 +++++++++++- src/panel/LogView.js | 6 ++++++ src/window/TaskViewer.js | 2 +- 3 files changed, 18 insertions(+), 2 deletions(-) proxmox-backup: Dominik Csapak (1): rest-server: tasks: percent-encode the task status line pbs-tools/src/percent_encoding.rs | 5 +++++ proxmox-rest-server/src/worker_task.rs | 4 +++- 2 files changed, 8 insertions(+), 1 deletion(-) -- 2.30.2