From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <d.csapak@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1A3497374A for <pve-devel@lists.proxmox.com>; Thu, 7 Oct 2021 15:46:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 11B431AC58 for <pve-devel@lists.proxmox.com>; Thu, 7 Oct 2021 15:45:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 607CA1AC37 for <pve-devel@lists.proxmox.com>; Thu, 7 Oct 2021 15:45:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2EA75458DA for <pve-devel@lists.proxmox.com>; Thu, 7 Oct 2021 15:45:32 +0200 (CEST) From: Dominik Csapak <d.csapak@proxmox.com> To: pve-devel@lists.proxmox.com Date: Thu, 7 Oct 2021 15:45:28 +0200 Message-Id: <20211007134531.1693674-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.303 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pci.pm, qemuserver.pm] Subject: [pve-devel] [PATCH qemu-server v3 0/3] fix #3258: check for in-use pci devices on vm start X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 07 Oct 2021 13:46:03 -0000 by having a vmid <-> pciid mapping in /var/run i did not check if the vm has the pci device really in the config, but we should not need that, since we remove the reservation again in the cleanup step and check the running pid anyway. notes: 1/3 is more or less independent, but made the code less crowded 3/3 is best viewed with -w since much of it is indentation change changes from v2: * add refactor of pci device preparation (could be independently applied) * always expect a list of ids in (un)reserve * really collect the whole list of ids before preparing changes from v1: * use time-based reservation before starting (current + start timeout +5s) and reserve again after we have the pid Dominik Csapak (3): pci: refactor pci device preparation pci: add helpers to (un)reserve pciids for a vm fix #3258: block vm start when pci device is already in use PVE/QemuServer.pm | 62 ++++++++++++++------- PVE/QemuServer/PCI.pm | 123 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 165 insertions(+), 20 deletions(-) -- 2.30.2