From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <d.csapak@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3B88D71CDB for <pve-devel@lists.proxmox.com>; Tue, 5 Oct 2021 13:29:38 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C8066274F1 for <pve-devel@lists.proxmox.com>; Tue, 5 Oct 2021 13:29:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 240E52747A for <pve-devel@lists.proxmox.com>; Tue, 5 Oct 2021 13:29:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id F157A456A3 for <pve-devel@lists.proxmox.com>; Tue, 5 Oct 2021 13:29:04 +0200 (CEST) From: Dominik Csapak <d.csapak@proxmox.com> To: pve-devel@lists.proxmox.com Date: Tue, 5 Oct 2021 13:28:56 +0200 Message-Id: <20211005112903.3649291-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.311 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: [pve-devel] [PATCH manager v3 0/7] multi disk/mp in wizard X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 05 Oct 2021 11:29:38 -0000 this series is a continuation of my previous multi tab / disk series[0] Introduces multi disk panels for vm and containers in the wizard. The UX is modeled after Dominics first attempt, but a very different approach code-wise. instead of having a seperate 'data' panel that contains the vm config, let the multi disk panel handle that and pass it through to the panels below. this way the HDEdit does not need a big code-change to get/set the config. changes from v2: * rebase on master (multi tab disk panel already applied) * refactor multi disk panel so that we can reuse it for containers * implement multi mp panel for container changes from v1: * fixed a bug which prevented the wizard from finishing * made the wizard a little wider so that the form field labes are readable * added logic to use the ostype to determine the first disk if one deleted all before 0: https://lists.proxmox.com/pipermail/pve-devel/2021-October/050215.html Dominik Csapak (7): ui: lxc/MPEdit: add updateVMConfig ui: lxc/MPEdit: fire diskidchange event ui: lxc/MPEdit: add selectFree toggle ui: add MultiDiskPanel ui: add lxc/MultiMPEdit and use in lxc/CreateWizard ui: add qemu/MultiHDEdit and use it in the wizard ui: window/Wizard: make it a little wider www/manager6/Makefile | 3 + www/manager6/lxc/CreateWizard.js | 8 +- www/manager6/lxc/MPEdit.js | 16 +- www/manager6/lxc/MultiMPEdit.js | 79 ++++++++ www/manager6/panel/MultiDiskEdit.js | 272 ++++++++++++++++++++++++++++ www/manager6/qemu/CreateWizard.js | 7 +- www/manager6/qemu/HDEdit.js | 9 +- www/manager6/qemu/MultiHDEdit.js | 62 +++++++ www/manager6/window/Wizard.js | 2 +- 9 files changed, 444 insertions(+), 14 deletions(-) create mode 100644 www/manager6/lxc/MultiMPEdit.js create mode 100644 www/manager6/panel/MultiDiskEdit.js create mode 100644 www/manager6/qemu/MultiHDEdit.js -- 2.30.2