all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit] panel/RRDCharts: enable scrolling for RRDCharts on touchscreens
Date: Thu,  5 Aug 2021 12:31:35 +0200	[thread overview]
Message-ID: <20210805103135.1287114-1-d.csapak@proxmox.com> (raw)

quote from extjs docs (AbstractChart.js):

 If you do have a chart inside a scrollable view, even if it has no
 interactions, you have to set its touchAction config to the following:

 touchAction: {
     panX: true,
     panY: true
 }

 Otherwise, if a touch action started on a chart,
 a swipe will not scroll the view.

Since we have RRDCharts always in a scrollable view, and it does not seem to
hurt non-touchscreens, enable it by default so that users on touchscreens
can scroll it.

Reported by users in the forum:
https://forum.proxmox.com/threads/minor-but-annoying-ipad-swipe-bug.93686

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/panel/RRDChart.js | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/panel/RRDChart.js b/src/panel/RRDChart.js
index d63170e..41533ea 100644
--- a/src/panel/RRDChart.js
+++ b/src/panel/RRDChart.js
@@ -155,6 +155,11 @@ Ext.define('Proxmox.widget.RRDChart', {
 	},
     },
 
+    touchAction: {
+	panX: true,
+	panY: true,
+    },
+
     constructor: function(config) {
 	let me = this;
 
-- 
2.30.2





             reply	other threads:[~2021-08-05 10:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05 10:31 Dominik Csapak [this message]
2021-08-23 16:17 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210805103135.1287114-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal