From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 25B3F76900
for <pbs-devel@lists.proxmox.com>; Fri, 16 Jul 2021 10:54:05 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 35428E2A6
for <pbs-devel@lists.proxmox.com>; Fri, 16 Jul 2021 10:53:34 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id 0E409E1B5
for <pbs-devel@lists.proxmox.com>; Fri, 16 Jul 2021 10:53:30 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DCCA741F49
for <pbs-devel@lists.proxmox.com>; Fri, 16 Jul 2021 10:53:29 +0200 (CEST)
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Date: Fri, 16 Jul 2021 10:53:27 +0200
Message-Id: <20210716085328.3731574-11-d.csapak@proxmox.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20210716085328.3731574-1-d.csapak@proxmox.com>
References: <20210716085328.3731574-1-d.csapak@proxmox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.577 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pbs-devel] [PATCH proxmox-backup 10/11] ui: datastore/Content: add
'Prune All' button
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Fri, 16 Jul 2021 08:54:05 -0000
since the api call always starts a real worker, we cannot have a
preview. It would also be very hard to show that for all groups in a
non-confusing way. We reuse the pbsPruneInputPanel and add the dry-run
field there conditionally.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/datastore/Content.js | 34 ++++++++++++++++++++++++++++++++++
www/window/DataStoreEdit.js | 15 +++++++++++++++
2 files changed, 49 insertions(+)
diff --git a/www/datastore/Content.js b/www/datastore/Content.js
index ac8ae1cc..57693785 100644
--- a/www/datastore/Content.js
+++ b/www/datastore/Content.js
@@ -340,6 +340,35 @@ Ext.define('PBS.DataStoreContent', {
});
},
+ pruneAll: function() {
+ let me = this;
+ let view = me.getView();
+
+ if (!view.datastore) return;
+
+ Ext.create('Proxmox.window.Edit', {
+ title: `Prune Datastore '${view.datastore}'`,
+ onlineHelp: 'maintenance_pruning',
+
+ method: 'POST',
+ submitText: "Prune",
+ autoShow: true,
+ isCreate: true,
+ showTaskViewer: true,
+
+ taskDone: () => me.reload(),
+
+ url: `/api2/extjs/admin/datastore/${view.datastore}/prune-datastore`,
+
+ items: [
+ {
+ xtype: 'pbsPruneInputPanel',
+ dryrun: true,
+ },
+ ],
+ });
+ },
+
onVerify: function(view, rI, cI, item, e, rec) {
let me = this;
view = me.getView();
@@ -865,6 +894,11 @@ Ext.define('PBS.DataStoreContent', {
confirmMsg: gettext('Do you want to verify all snapshots now?'),
handler: 'verifyAll',
},
+ {
+ xtype: 'proxmoxButton',
+ text: gettext('Prune All'),
+ handler: 'pruneAll',
+ },
'->',
{
xtype: 'tbtext',
diff --git a/www/window/DataStoreEdit.js b/www/window/DataStoreEdit.js
index fbf0da5b..ed23ad11 100644
--- a/www/window/DataStoreEdit.js
+++ b/www/window/DataStoreEdit.js
@@ -6,6 +6,9 @@ Ext.define('PBS.panel.PruneInputPanel', {
onlineHelp: 'maintenance_pruning',
+ // show/hide dry-run field
+ dryrun: false,
+
cbindData: function() {
let me = this;
me.isCreate = !!me.isCreate;
@@ -65,6 +68,18 @@ Ext.define('PBS.panel.PruneInputPanel', {
},
],
+ columnB: [
+ {
+ xtype: 'proxmoxcheckbox',
+ name: 'dry-run',
+ fieldLabel: gettext('Dry Run'),
+ cbind: {
+ hidden: '{!dryrun}',
+ disabled: '{!dryrun}',
+ },
+ },
+ ],
+
});
Ext.define('PBS.DataStoreEdit', {
extend: 'Proxmox.window.Edit',
--
2.30.2