From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <s.ivanov@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id C0F3976135
for <pve-devel@lists.proxmox.com>; Wed, 14 Jul 2021 18:52:49 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 8EE04151E7
for <pve-devel@lists.proxmox.com>; Wed, 14 Jul 2021 18:52:19 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id 7D15F151DC
for <pve-devel@lists.proxmox.com>; Wed, 14 Jul 2021 18:52:18 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 476D2418DD
for <pve-devel@lists.proxmox.com>; Wed, 14 Jul 2021 18:52:18 +0200 (CEST)
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Wed, 14 Jul 2021 18:52:04 +0200
Message-Id: <20210714165204.262432-1-s.ivanov@proxmox.com>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.447 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH] fix compressor loop-order
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 14 Jul 2021 16:52:49 -0000
commit dbac106eb6e3cff405e57c0bb6a6dbe3cf307c52 introduced a flaw in
the logic - once a file is downloaded the 'last;' statement exited the
inner loop iterating over the compoentens instead of the outer one
iterating over the compressors.
since both do not inherently depend on each other simply swap them.
noticed while trying to build a pmg-template in a clean environment
with full repository configuration (before the tests worked due to
leftover files in the infodir)
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
Sorry for the inconvenience!
DAB.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/DAB.pm b/DAB.pm
index b81321e..9282789 100644
--- a/DAB.pm
+++ b/DAB.pm
@@ -648,8 +648,8 @@ sub initialize {
warn "Release info ignored\n";
};
- foreach my $compressor (@$COMPRESSORS) {
- foreach my $comp (@{$ss->{comp}}) {
+ foreach my $comp (@{$ss->{comp}}) {
+ foreach my $compressor (@$COMPRESSORS) {
$path = "dists/$ss->{suite}/$comp/binary-$arch/Packages.$compressor->{ext}";
$target = "$infodir/" . __url_to_filename ("$ss->{source}/$path");
my $pkgsrc = "$src/$path";
--
2.30.2