From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <f.ebner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 1D47C737C9
for <pve-devel@lists.proxmox.com>; Fri, 18 Jun 2021 13:00:15 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id D253526B55
for <pve-devel@lists.proxmox.com>; Fri, 18 Jun 2021 12:59:44 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id A25A626B6F
for <pve-devel@lists.proxmox.com>; Fri, 18 Jun 2021 12:59:42 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 66B2B44214
for <pve-devel@lists.proxmox.com>; Fri, 18 Jun 2021 12:59:42 +0200 (CEST)
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Fri, 18 Jun 2021 12:59:29 +0200
Message-Id: <20210618105938.57107-1-f.ebner@proxmox.com>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.735 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [pve6to7.pm, qemumigrate.pm, plugin.pm, qemu.pm, qemuserver.pm,
storage.pm]
Subject: [pve-devel] [PATCH-SERIES] stricter storage rules for migration
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Fri, 18 Jun 2021 11:00:15 -0000
Enforce that affected storages are enabled and have the correct content type
before doing a migration. And only pick up unreferenced guest volumes from
storages that support the content type.
Can be considered a breaking change, but it'll only affect scenarios where there
is a guest's volume on a misconfigured storage, so it can also be considered a
bug fix. Still, best to do it for a major release.
Another small change regarding misconfigured 'none' content type is thrown in,
patches storage #2 and manager #2, which also should rather be done for a major
release.
Dependency-wise, only patch storage #1 is relevant, as it breaks older migration
code, but should also be limited to scenarios with unused/unreferenced/vmstate
local disks *and* misconfigured storage.
pve-container:
Fabian Ebner (3):
prefer storage_check_enabled over storage_check_node
migrate: also test unused volumes
migrate: enforce that rootdir content type is available
qemu-server:
Fabian Ebner (2):
prefer storage_check_enabled over storage_check_node
migrate: enforce that image content type is available
PVE/API2/Qemu.pm | 4 ++--
PVE/QemuMigrate.pm | 31 +++++++++++++++++++------------
PVE/QemuServer.pm | 7 +++++--
3 files changed, 26 insertions(+), 16 deletions(-)
pve-storage:
Fabian Ebner (2):
vdisk_list: only scan storages with the correct content type(s)
config: prevent empty content list when content type 'none' is not
supported
PVE/Storage.pm | 8 ++------
PVE/Storage/Plugin.pm | 4 ++++
2 files changed, 6 insertions(+), 6 deletions(-)
pve-manager:
Fabian Ebner (2):
pve6to7: add check for guest images on misconfigured storages
pve6to7: check for misconfigured content type 'none'
PVE/CLI/pve6to7.pm | 50 ++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 50 insertions(+)
--
2.20.1