From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <o.bektas@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E92F472CB0 for <pve-devel@lists.proxmox.com>; Wed, 16 Jun 2021 16:05:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D4135127CC for <pve-devel@lists.proxmox.com>; Wed, 16 Jun 2021 16:04:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5DA0F127C0 for <pve-devel@lists.proxmox.com>; Wed, 16 Jun 2021 16:04:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 218DF4404D for <pve-devel@lists.proxmox.com>; Wed, 16 Jun 2021 16:04:31 +0200 (CEST) Date: Wed, 16 Jun 2021 16:04:29 +0200 From: Oguz Bektas <o.bektas@proxmox.com> To: Thomas Lamprecht <t.lamprecht@proxmox.com> Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Message-ID: <20210616140429.GA14060@gaia.proxmox.com> Mail-Followup-To: Oguz Bektas <o.bektas@proxmox.com>, Thomas Lamprecht <t.lamprecht@proxmox.com>, Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <20210616132422.1768676-1-o.bektas@proxmox.com> <5d74bd92-63b0-5525-a7e1-7a561e92d54d@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5d74bd92-63b0-5525-a7e1-7a561e92d54d@proxmox.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-SPAM-LEVEL: Spam detection results: 0 AWL 1.850 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [base.pm, lxc.pm, setup.pm] Subject: Re: [pve-devel] [PATCH v4 container 0/2] post_clone hook for containers X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 16 Jun 2021 14:05:02 -0000 On Wed, Jun 16, 2021 at 03:48:42PM +0200, Thomas Lamprecht wrote: > On 16.06.21 15:24, Oguz Bektas wrote: > > fixes #3443 by implementing post_clone_hook for containers (which at the > > moment only generates a unique /etc/machine-id for the cloned > > container). this can be reused later for other things we want to do post > > clone. > > > > what are the changes since v3? I did not found any note here nor in the actual > patches. oops. sorry! v3->v4: * call generic post_clone_hook in setup code instead of directly calling clear_machine_id in clone_vm API * improve config locking in clone_vm API (don't write to config file without checking/obtaining lock on it) * clone firewall config _inside_ worker instead of _before_ worker * fixed minor typo in error message for bind mounts > > > > > > > Oguz Bektas (2): > > setup: add post_clone_hook for containers > > run post_clone_hook in clone_vm > > > > src/PVE/API2/LXC.pm | 37 ++++++++++++++++++++++++++++++------- > > src/PVE/LXC/Setup.pm | 12 ++++++++++++ > > src/PVE/LXC/Setup/Base.pm | 31 +++++++++++++++++++++++++++++++ > > 3 files changed, 73 insertions(+), 7 deletions(-) > > >