From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id E53B572ACE
for <pbs-devel@lists.proxmox.com>; Wed, 26 May 2021 11:12:38 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id D278BF1F4
for <pbs-devel@lists.proxmox.com>; Wed, 26 May 2021 11:12:08 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id B2FA5F1B6
for <pbs-devel@lists.proxmox.com>; Wed, 26 May 2021 11:12:07 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8752346671
for <pbs-devel@lists.proxmox.com>; Wed, 26 May 2021 11:12:07 +0200 (CEST)
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Date: Wed, 26 May 2021 11:12:01 +0200
Message-Id: <20210526091206.21979-5-d.csapak@proxmox.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20210526091206.21979-1-d.csapak@proxmox.com>
References: <20210526091206.21979-1-d.csapak@proxmox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.037 Adjusted score from AWL reputation of From: address
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pbs-devel] [PATCH proxmox-backup 4/9] ui: datastore/Summary:
change destroy listener
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 26 May 2021 09:12:38 -0000
by using beforedestroy instead of destroy (like we do everywhere else)
to avoid race condition when the controller has
already removed some handlers on destruction
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/datastore/Summary.js | 2 +-
www/tape/ChangerStatus.js | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/datastore/Summary.js b/www/datastore/Summary.js
index 25a7b6e5..998b6297 100644
--- a/www/datastore/Summary.js
+++ b/www/datastore/Summary.js
@@ -86,7 +86,7 @@ Ext.define('PBS.DataStoreInfo', {
listeners: {
activate: 'startStore',
- destroy: 'stopStore',
+ beforedestroy: 'stopStore',
deactivate: 'stopStore',
},
diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js
index 51ba6ffa..0fad11b3 100644
--- a/www/tape/ChangerStatus.js
+++ b/www/tape/ChangerStatus.js
@@ -668,7 +668,7 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
listeners: {
deactivate: 'cancelReload',
- destroy: 'cancelReload',
+ beforedestroy: 'cancelReload',
},
tbar: [
--
2.20.1