From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <d.jaeger@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 2C9CF715BA
for <pve-devel@lists.proxmox.com>; Wed, 19 May 2021 11:15:16 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 15980185CF
for <pve-devel@lists.proxmox.com>; Wed, 19 May 2021 11:14:46 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id 969A4185C3
for <pve-devel@lists.proxmox.com>; Wed, 19 May 2021 11:14:45 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0862346602
for <pve-devel@lists.proxmox.com>; Wed, 19 May 2021 11:14:39 +0200 (CEST)
From: =?UTF-8?q?Dominic=20J=C3=A4ger?= <d.jaeger@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Wed, 19 May 2021 11:14:18 +0200
Message-Id: <20210519091419.18921-1-d.jaeger@proxmox.com>
X-Mailer: git-send-email 2.20.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.802 Adjusted score from AWL reputation of From: address
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH manager 1/2] ui: qemu: eslint fixes
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 19 May 2021 09:15:16 -0000
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
---
These 2 patches fix the remaining errors for manager6/qemu and manager6/storage
(manager6/lxc is already OK)
www/manager6/qemu/CmdMenu.js | 2 +-
www/manager6/qemu/PCIEdit.js | 7 +++++--
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/www/manager6/qemu/CmdMenu.js b/www/manager6/qemu/CmdMenu.js
index e312119d..fa75ad82 100644
--- a/www/manager6/qemu/CmdMenu.js
+++ b/www/manager6/qemu/CmdMenu.js
@@ -85,7 +85,7 @@ Ext.define('PVE.qemu.CmdMenu', {
text: gettext('Shutdown'),
iconCls: 'fa fa-fw fa-power-off',
disabled: stopped || suspended,
- handler: () => confirmedVMCommand('shutdown'),
+ handler: () => confirmedVMCommand('shutdown'),
},
{
text: gettext('Stop'),
diff --git a/www/manager6/qemu/PCIEdit.js b/www/manager6/qemu/PCIEdit.js
index 942e8aed..a8e05f2d 100644
--- a/www/manager6/qemu/PCIEdit.js
+++ b/www/manager6/qemu/PCIEdit.js
@@ -124,11 +124,14 @@ Ext.define('PVE.qemu.PCIInputPanel', {
if (iommu !== -1) {
var count = 0;
pcisel.getStore().each(function(record) {
- if (record.data.iommugroup === iommu &&
- record.data.id.substring(0, 5) !== id) {
+ if (
+ record.data.iommugroup === iommu &&
+ record.data.id.substring(0, 5) !== id
+ ) {
count++;
return false;
}
+ return true;
});
var warning = me.down('#iommuwarning');
if (count && !warning) {
--
2.20.1