From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <d.jaeger@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 616CC713C9
for <pve-devel@lists.proxmox.com>; Tue, 18 May 2021 14:13:14 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 4D295F054
for <pve-devel@lists.proxmox.com>; Tue, 18 May 2021 14:12:44 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id 8C397F033
for <pve-devel@lists.proxmox.com>; Tue, 18 May 2021 14:12:42 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 639F1465CE
for <pve-devel@lists.proxmox.com>; Tue, 18 May 2021 14:12:42 +0200 (CEST)
From: =?UTF-8?q?Dominic=20J=C3=A4ger?= <d.jaeger@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Tue, 18 May 2021 14:12:18 +0200
Message-Id: <20210518121218.125661-7-d.jaeger@proxmox.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20210518121218.125661-1-d.jaeger@proxmox.com>
References: <20210518121218.125661-1-d.jaeger@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 1
AWL 1.002 Adjusted score from AWL reputation of From: address
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH manager 6/6] Miscellaneous eslint fixes
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 18 May 2021 12:13:14 -0000
Function syntax, raw words, string templates, no prototype builtins
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
---
www/manager6/lxc/MPResize.js | 5 -----
www/manager6/qemu/HDResize.js | 4 ----
www/manager6/qemu/OSDefaults.js | 2 +-
www/manager6/storage/Base.js | 2 +-
www/manager6/storage/ImageView.js | 3 +--
www/manager6/storage/ZFSEdit.js | 2 +-
6 files changed, 4 insertions(+), 14 deletions(-)
diff --git a/www/manager6/lxc/MPResize.js b/www/manager6/lxc/MPResize.js
index f73c5c3f..881c037b 100644
--- a/www/manager6/lxc/MPResize.js
+++ b/www/manager6/lxc/MPResize.js
@@ -91,11 +91,6 @@ Ext.define('PVE.window.MPResize', {
items: [me.formPanel],
});
-
me.callParent();
-
- if (!me.disk) {
- return;
- }
},
});
diff --git a/www/manager6/qemu/HDResize.js b/www/manager6/qemu/HDResize.js
index a18e242c..f9c7290d 100644
--- a/www/manager6/qemu/HDResize.js
+++ b/www/manager6/qemu/HDResize.js
@@ -92,9 +92,5 @@ Ext.define('PVE.window.HDResize', {
me.callParent();
-
- if (!me.disk) {
- return;
- }
},
});
diff --git a/www/manager6/qemu/OSDefaults.js b/www/manager6/qemu/OSDefaults.js
index 8e585651..f464133e 100644
--- a/www/manager6/qemu/OSDefaults.js
+++ b/www/manager6/qemu/OSDefaults.js
@@ -24,7 +24,7 @@ Ext.define('PVE.qemu.OSDefaults', {
var me = this;
var addOS = function(settings) {
- if (me.hasOwnProperty(settings.parent)) {
+ if (Object.prototype.hasOwnProperty.call(settings, 'parent')) {
var child = Ext.clone(me[settings.parent]);
me[settings.pveOS] = Ext.apply(child, settings);
} else {
diff --git a/www/manager6/storage/Base.js b/www/manager6/storage/Base.js
index 4336d634..20ec3464 100644
--- a/www/manager6/storage/Base.js
+++ b/www/manager6/storage/Base.js
@@ -78,7 +78,7 @@ Ext.define('PVE.panel.StoragePruneInputPanel', {
}
// always delete old 'maxfiles' on edit, we map it to keep-last on window load
return {
- delete: ['prune-backups', 'maxfiles'],
+ 'delete': ['prune-backups', 'maxfiles'],
};
}
let options = { 'prune-backups': retention };
diff --git a/www/manager6/storage/ImageView.js b/www/manager6/storage/ImageView.js
index dda4b8e6..69517b5e 100644
--- a/www/manager6/storage/ImageView.js
+++ b/www/manager6/storage/ImageView.js
@@ -33,8 +33,7 @@ Ext.define('PVE.storage.ImageView', {
text: gettext('Remove'),
disabled: true,
handler: function(btn, event, rec) {
- var url = "/nodes/" + nodename + "/storage/" + storage +
- "/content" + '/' + rec.data.volid;
+ let url = `/nodes/${nodename}/storage/${storage}/content/${rec.data.volid}`;
var vmid = rec.data.vmid;
var store = PVE.data.ResourceStore;
diff --git a/www/manager6/storage/ZFSEdit.js b/www/manager6/storage/ZFSEdit.js
index e348d1a1..0c5a3ceb 100644
--- a/www/manager6/storage/ZFSEdit.js
+++ b/www/manager6/storage/ZFSEdit.js
@@ -38,7 +38,7 @@ Ext.define('PVE.storage.ZFSInputPanel', {
return me.callParent([values]);
},
- setValues: function diff(values) {
+ setValues: function(values) {
values.writecache = values.nowritecache ? 0 : 1;
this.callParent([values]);
},
--
2.20.1