From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <d.csapak@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 10BAB71085 for <pve-devel@lists.proxmox.com>; Mon, 17 May 2021 15:08:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0303C2C0C6 for <pve-devel@lists.proxmox.com>; Mon, 17 May 2021 15:07:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id F32B72C0A6 for <pve-devel@lists.proxmox.com>; Mon, 17 May 2021 15:07:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BDD37465BA for <pve-devel@lists.proxmox.com>; Mon, 17 May 2021 15:07:35 +0200 (CEST) From: Dominik Csapak <d.csapak@proxmox.com> To: pve-devel@lists.proxmox.com Date: Mon, 17 May 2021 15:07:33 +0200 Message-Id: <20210517130735.17568-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH http-server 0/2] remove unnecessary websocket code X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Mon, 17 May 2021 13:08:11 -0000 we do not need/want any websocket subprotocol handling, nor do we need 'base64' encoding/decoding, so drop it we can drop the protocols in the clients (novnc/xtermjs) with the next major release after this is released, else the cluster console will not work. the compatibility code here can then be dropped one major release after so if we opt to apply it now for 6.4 still, we may get away with dropping the client protocol for 7.x, and the compat code with 8.0 else we have to wait for 8.0 to drop the client code, and 9.0 for the compat code Dominik Csapak (2): AnyEvent/websocket_proxy: remove 'base64' handling AnyEvent/websocket_proxy: drop handling of websocket subprotocols src/PVE/APIServer/AnyEvent.pm | 34 +++++++--------------------------- 1 file changed, 7 insertions(+), 27 deletions(-) -- 2.20.1