From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <d.jaeger@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D5B8E7526E for <pbs-devel@lists.proxmox.com>; Wed, 21 Apr 2021 14:03:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C9D10EA45 for <pbs-devel@lists.proxmox.com>; Wed, 21 Apr 2021 14:03:58 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 52A89EA3A for <pbs-devel@lists.proxmox.com>; Wed, 21 Apr 2021 14:03:55 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E10CF41643 for <pbs-devel@lists.proxmox.com>; Wed, 21 Apr 2021 13:56:20 +0200 (CEST) Date: Wed, 21 Apr 2021 13:56:18 +0200 From: Dominic =?iso-8859-1?Q?J=E4ger?= <d.jaeger@proxmox.com> To: Wolfgang Bumiller <w.bumiller@proxmox.com>, Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Cc: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Message-ID: <20210421115618.GA87005@mala> References: <137355824.4295.1618915991154@webmail.proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <137355824.4295.1618915991154@webmail.proxmox.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-SPAM-LEVEL: Spam detection results: 1 AWL 1.328 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [dominicjaeger.com, acme.sh, letsencrypt.org] Subject: Re: [pbs-devel] [RFC backup 00/23] Implements ACME suport for PBS X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 21 Apr 2021 12:03:58 -0000 I am not sure how much of what I noticed today is for this series or general On Tue, Apr 20, 2021 at 12:53:11PM +0200, Wolfgang Bumiller wrote: > > In the window "Register Account" the textfield "Account Name" has the empty > > text "default". As far as I know, we use empty texts for real default values. > > So this should be removed and get a validator (already in the GUI) instead. > > GUI specifics aren't really in scope of this series as this just reuses the existing components. > So this should be handled separately. or would be magically solved by the packaging changes > > Yeah we should turn the proxmox-acme repo into a split package and have the acme.sh > wrapper separate so we can depend/suggest that without pulling in the perl code. but a few things looked working to me in PVE but not PBS: 1. In the "Create: Domain" window, when attempting to create a duplicate entry: PVE shows an error "duplicate domain" while PBS silently replaces the previous entry 2. I installed libproxmox-acme-perl as disucssed. The dropdown list for DNS API then did appear. However, I haven't found a dropdown entry yet that made the general API Data field change to the API specific fields. This includes APIs like kappernet for which this certainly works in PVE. 3. When trying around I got some error like > TASK ERROR: validating challenge 'https://acme-staging-v02.api.letsencrypt.org/acme/...' failed - status: Invalid and after editing (=removing a line) the contents of the API Data field the error message became less useful >Placing ACME order >Order URL: https://acme-staging-v02.api.letsencrypt.org/acme/order/.... >Getting authorization details from 'https://acme-staging-v02.api.letsencrypt.org/acme/authz-v3/...' >The validation for dominicjaeger.com is pending >Setting up validation plugin >TASK ERROR: '/usr/share/proxmox-acme/proxmox-acme setup' exited with error (1) Would it be possible to show more reasons for the error here? 4. The dropdown list is different for PBS and PVE. For example, PVE contains "Cloudflare Managed DNS" while PBS contains just "cf"