From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <s.reiter@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 872B7752DD for <pve-devel@lists.proxmox.com>; Wed, 21 Apr 2021 13:24:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E88A8E0D4 for <pve-devel@lists.proxmox.com>; Wed, 21 Apr 2021 13:24:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0D017DFDE for <pve-devel@lists.proxmox.com>; Wed, 21 Apr 2021 13:23:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5D47F4622E for <pve-devel@lists.proxmox.com>; Wed, 21 Apr 2021 13:15:46 +0200 (CEST) From: Stefan Reiter <s.reiter@proxmox.com> To: pve-devel@lists.proxmox.com Date: Wed, 21 Apr 2021 13:15:29 +0200 Message-Id: <20210421111539.29261-1-s.reiter@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, anyevent.pm, pbsclient.pm, status.pm, jsonschema.pm, filerestore.pm] Subject: [pve-devel] [PATCH 00/10] Single-file-restore GUI for PBS snapshots X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 21 Apr 2021 11:24:32 -0000 Implements the necessary API for allowing single file restore via the PVE web GUI. This requires some adaptations of the HTTP server, to allow data streaming without buffering - otherwise bigger restores would a) use up too much memory b) get slowed down by the pvedaemon->pveproxy->client return path. Instead, we transfer the data via a temporary FIFO. Known issues/further work: * restore VMs are not shown or stopped, they always run until timeout. Ideas would be to stop them when a user closes the restore window (but what if another user/tab/... is using the VM too?), or start a worker task for them (how to detect new VMs? parse proxmox-file-restore status before and after command?). Thoughts appreciated :) * restarting the daemon or proxy marks the worker as failed and correctly stops it, but the browser says the download is OK - just with not enough data. Not the best experience, but unsure on how to fix this. Chunked encoding maybe, and terminate with an invalid chunk in case of error/abort? * downloading an entire container archive (clicking on the root) doesn't currently work. I'll fix that in proxmox-file-restore. Not required, but looks better with: https://lists.proxmox.com/pipermail/pbs-devel/2021-April/002595.html common: Stefan Reiter (5): JSONSchema: don't cycle-check 'download' responses PBSClient: allow running other binaries PBSClient: add file_restore_list command PBSClient: allow different command execution callback PBSClient: add file_restore_extract function src/PVE/JSONSchema.pm | 5 +- src/PVE/PBSClient.pm | 107 +++++++++++++++++++++++++++++++++++------- 2 files changed, 94 insertions(+), 18 deletions(-) http-server: Stefan Reiter (3): allow 'download' to be passed from API handler support streaming data form fh to client allow stream download from path and over pvedaemon-proxy PVE/APIServer/AnyEvent.pm | 142 +++++++++++++++++++++++++++++++++++--- 1 file changed, 133 insertions(+), 9 deletions(-) storage: Stefan Reiter (1): add FileRestore API for PBS PVE/API2/Storage/FileRestore.pm | 163 ++++++++++++++++++++++++++++++++ PVE/API2/Storage/Makefile | 2 +- PVE/API2/Storage/Status.pm | 6 ++ 3 files changed, 170 insertions(+), 1 deletion(-) create mode 100644 PVE/API2/Storage/FileRestore.pm manager: Stefan Reiter (1): backupview: add file restore button www/manager6/grid/BackupView.js | 23 +++++++++++++++++++++++ www/manager6/storage/BackupView.js | 19 +++++++++++++++++++ 2 files changed, 42 insertions(+) -- 2.20.1