From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <f.ebner@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6B40774A03 for <pve-devel@lists.proxmox.com>; Mon, 19 Apr 2021 15:14:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1AB711634D for <pve-devel@lists.proxmox.com>; Mon, 19 Apr 2021 15:14:54 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B3E381624B for <pve-devel@lists.proxmox.com>; Mon, 19 Apr 2021 15:14:46 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7D06845B12 for <pve-devel@lists.proxmox.com>; Mon, 19 Apr 2021 15:14:46 +0200 (CEST) From: Fabian Ebner <f.ebner@proxmox.com> To: pve-devel@lists.proxmox.com Date: Mon, 19 Apr 2021 15:14:39 +0200 Message-Id: <20210419131441.23650-6-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210419131441.23650-1-f.ebner@proxmox.com> References: <20210419131441.23650-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.007 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 5/7] ui: safe destroy guest: add checkbox for removal of unreferenced disks X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Mon, 19 Apr 2021 13:14:54 -0000 Signed-off-by: Fabian Ebner <f.ebner@proxmox.com> --- Dependency bump for pve-container and qemu-server is needed. Ideally, the dependency bump for qemu-server also includes [0], so people with snapshots don't run into left-over VM state disks. [0]: https://lists.proxmox.com/pipermail/pve-devel/2021-April/047685.html www/manager6/window/SafeDestroyGuest.js | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/www/manager6/window/SafeDestroyGuest.js b/www/manager6/window/SafeDestroyGuest.js index d6121594..a8a86d07 100644 --- a/www/manager6/window/SafeDestroyGuest.js +++ b/www/manager6/window/SafeDestroyGuest.js @@ -17,6 +17,17 @@ Ext.define('PVE.window.SafeDestroyGuest', { 'data-qtip': gettext('Remove from replication and backup jobs'), }, }, + { + xtype: 'proxmoxcheckbox', + name: 'destroyUnreferenced', + reference: 'destroyUnreferencedCheckbox', + boxLabel: gettext('Destroy unreferenced disks'), + checked: false, + autoEl: { + tag: 'div', + 'data-qtip': gettext('Scan all storages for unreferenced disks'), + }, + }, ], getParams: function() { @@ -25,6 +36,9 @@ Ext.define('PVE.window.SafeDestroyGuest', { const purgeCheckbox = me.lookupReference('purgeCheckbox'); me.params.purge = purgeCheckbox.checked ? 1 : 0; + const destroyUnreferencedCheckbox = me.lookupReference('destroyUnreferencedCheckbox'); + me.params["destroy-unreferenced-disks"] = destroyUnreferencedCheckbox.checked ? 1 : 0; + return me.callParent(); }, }); -- 2.20.1