From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <f.ebner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 3ED7974959
for <pve-devel@lists.proxmox.com>; Mon, 19 Apr 2021 15:14:50 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 1853C1624E
for <pve-devel@lists.proxmox.com>; Mon, 19 Apr 2021 15:14:50 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[212.186.127.180])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id 077E916223
for <pve-devel@lists.proxmox.com>; Mon, 19 Apr 2021 15:14:46 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BD3A645B6D
for <pve-devel@lists.proxmox.com>; Mon, 19 Apr 2021 15:14:45 +0200 (CEST)
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Mon, 19 Apr 2021 15:14:35 +0200
Message-Id: <20210419131441.23650-2-f.ebner@proxmox.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20210419131441.23650-1-f.ebner@proxmox.com>
References: <20210419131441.23650-1-f.ebner@proxmox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.007 Adjusted score from AWL reputation of From: address
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/,
medium trust
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_SBL 0.644 Contains an URL's NS IP listed in the Spamhaus SBL blocklist
[item.id]
Subject: [pve-devel] [PATCH proxmox-widget-toolkit 1/7] safe destroy: remove
purge checkbox
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 19 Apr 2021 13:14:50 -0000
To be replaced by generic additional items specified by the user of the window
or child class. AFAICS there are no existing users of this widget yet, so this
shouldn't break anything.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
src/window/SafeDestroy.js | 23 +----------------------
1 file changed, 1 insertion(+), 22 deletions(-)
diff --git a/src/window/SafeDestroy.js b/src/window/SafeDestroy.js
index 87f81b7..91e0f2c 100644
--- a/src/window/SafeDestroy.js
+++ b/src/window/SafeDestroy.js
@@ -18,7 +18,6 @@ Ext.define('Proxmox.window.SafeDestroy', {
config: {
item: {
id: undefined,
- purgeable: false,
},
url: undefined,
note: undefined,
@@ -28,10 +27,7 @@ Ext.define('Proxmox.window.SafeDestroy', {
getParams: function() {
let me = this;
- const purgeCheckbox = me.lookupReference('purgeCheckbox');
- if (purgeCheckbox.checked) {
- me.params.purge = 1;
- }
+
if (Ext.Object.isEmpty(me.params)) {
return '';
}
@@ -128,17 +124,6 @@ Ext.define('Proxmox.window.SafeDestroy', {
hideTrigger: true,
allowBlank: false,
},
- {
- xtype: 'proxmoxcheckbox',
- name: 'purge',
- reference: 'purgeCheckbox',
- boxLabel: gettext('Purge'),
- checked: false,
- autoEl: {
- tag: 'div',
- 'data-qtip': gettext('Remove from replication and backup jobs'),
- },
- },
{
xtype: 'container',
reference: 'noteContainer',
@@ -198,12 +183,6 @@ Ext.define('Proxmox.window.SafeDestroy', {
throw "no task name specified";
}
- if (!item.purgeable) {
- const purgeCheckbox = me.lookupReference('purgeCheckbox');
- purgeCheckbox.setDisabled(true);
- purgeCheckbox.setHidden(true);
- }
-
const confirmField = me.lookupReference('confirmField');
msg = gettext('Please enter the ID to confirm') +
' (' + item.id + ')';
--
2.20.1