From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3F70F69F8E for ; Wed, 24 Mar 2021 11:41:24 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2F07337C7A for ; Wed, 24 Mar 2021 11:40:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 63FB537C6F for ; Wed, 24 Mar 2021 11:40:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3017C42DFC for ; Wed, 24 Mar 2021 11:40:53 +0100 (CET) Date: Wed, 24 Mar 2021 11:38:12 +0100 From: Oguz Bektas To: Fabian Ebner Cc: pve-devel@lists.proxmox.com Message-ID: <20210324103812.GB10674@gaia.proxmox.com> Mail-Followup-To: Oguz Bektas , Fabian Ebner , pve-devel@lists.proxmox.com References: <20210322140045.763332-1-o.bektas@proxmox.com> <20210322140045.763332-2-o.bektas@proxmox.com> <75ad2e3f-48c4-0ab5-c1ed-95fa268a7025@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <75ad2e3f-48c4-0ab5-c1ed-95fa268a7025@proxmox.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-SPAM-LEVEL: Spam detection results: 0 AWL 1.246 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [daemon.pm, perl.org] Subject: Re: [pve-devel] [PATCH v3 common 1/3] daemon: listen also on ipv6 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2021 10:41:24 -0000 On Wed, Mar 24, 2021 at 09:37:03AM +0100, Fabian Ebner wrote: > Note that for pmgproxy this is still called this with (8006, undef, > $family). Did you ensure that this is backwards-compatible? Otherwise this > needs versioned breaks and the call for pmgproxy needs to be adapted too. it seems to be backwards compatible i did the following now to test: 1. update pmg to latest 2. install .deb of libpve-common-perl with my change 3. systemctl restart pmgproxy and it worked still as expected (with no behavior change). > > Am 22.03.21 um 15:00 schrieb Oguz Bektas: > > see [0] > > when we set 'Domain' to PF_INET6 by default, it will prefer IPv6. since > > we don't set 'V6Only' it will also listen on IPv4 interfaces. > > > > 'Family' parameter isn't needed anymore. > > > > this change depends on the changes in pve-manager and pve-http-server to > > work correctly. > > > > [0]: > > https://perldoc.perl.org/IO::Socket::IP#REPLACING-IO::Socket-DEFAULT-BEHAVIOUR > > > > Signed-off-by: Oguz Bektas > > --- > > src/PVE/Daemon.pm | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/src/PVE/Daemon.pm b/src/PVE/Daemon.pm > > index 64f8126..76601d5 100644 > > --- a/src/PVE/Daemon.pm > > +++ b/src/PVE/Daemon.pm > > @@ -820,10 +820,10 @@ sub create_reusable_socket { > > } else { > > $socket = IO::Socket::IP->new( > > - LocalAddr => $host, > > + Domain => PF_INET6, > > + LocalHost => $host, > > LocalPort => $port, > > Listen => SOMAXCONN, > > - Family => $family, > > Proto => 'tcp', > > GetAddrInfoFlags => 0, > > ReuseAddr => 1) || > >