From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <root@kvmformation3.odiso.net> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BAC226C007 for <pve-devel@lists.proxmox.com>; Fri, 19 Mar 2021 13:16:31 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 98FAC2260A for <pve-devel@lists.proxmox.com>; Fri, 19 Mar 2021 13:16:31 +0100 (CET) Received: from kvmformation3.odiso.net (globalOdiso.M6Lille.odiso.net [89.248.211.242]) by firstgate.proxmox.com (Proxmox) with ESMTP id BA14A225C5 for <pve-devel@lists.proxmox.com>; Fri, 19 Mar 2021 13:16:26 +0100 (CET) Received: by kvmformation3.odiso.net (Postfix, from userid 0) id 4F73C7733E; Fri, 19 Mar 2021 13:06:58 +0100 (CET) From: Alexandre Derumier <aderumier@odiso.com> To: pve-devel@lists.proxmox.com Date: Fri, 19 Mar 2021 13:06:52 +0100 Message-Id: <20210319120656.86740-1-aderumier@odiso.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -0.175 Adjusted score from AWL reputation of From: address HEADER_FROM_DIFFERENT_DOMAINS 0.25 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods KHOP_HELO_FCRDNS 0.399 Relay HELO differs from its IP's reverse DNS NO_DNS_FOR_FROM 0.379 Envelope sender has no MX or A DNS records SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm, cloudinit.pm, qemu.pm] Subject: [pve-devel] [PATCH qemu-server 0/4] RFC: cloudinit pending behaviour change X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 19 Mar 2021 12:16:31 -0000 Hi, This is an attempt to cleanup current behaviour of cloudinit online changes. Currently, we setup cloudinit options as pending, until we generate the config drive. This is not 100% true, because some option like vm name, nic mac address can be changed, without going to pending, so user can't known if it need to regenerated it. Also, some can are very difficult to handle, if you hotplug a nic but it's failing,so pending, then you defined an ipconfig, and then you revert hotplug. or if you delete a nic, the ipconfig is no more displayed in the gui. So, instead of setting cloudinit values in pending, this patch serie copy the current cloudinit config in a new section [CLOUDINIT], when the config drive is generated. This is only an hint, to allow to display diff between the generated cloudinit drive, and the current vm config. A new specific cloudinit config api is added too, merging ipaddrX && netX mac in same field, and displaying the diff between current and generated config. Alexandre Derumier (4): cloudinit: add cloudinit section for current generated config. generate cloudinit when vm is offline too cloudinit: make cloudnit options fastplug api2: add cloudinit config api PVE/API2/Qemu.pm | 132 ++++++++++++++++++++++++++++++++++++ PVE/QemuServer.pm | 60 ++++++++-------- PVE/QemuServer/Cloudinit.pm | 32 +++++++++ 3 files changed, 193 insertions(+), 31 deletions(-) -- 2.20.1