From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <d.csapak@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DCEFF6A737 for <pbs-devel@lists.proxmox.com>; Mon, 15 Mar 2021 12:21:50 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D5C2C202DD for <pbs-devel@lists.proxmox.com>; Mon, 15 Mar 2021 12:21:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B4695202C2 for <pbs-devel@lists.proxmox.com>; Mon, 15 Mar 2021 12:21:19 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7936C42733 for <pbs-devel@lists.proxmox.com>; Mon, 15 Mar 2021 12:21:19 +0100 (CET) From: Dominik Csapak <d.csapak@proxmox.com> To: pbs-devel@lists.proxmox.com Date: Mon, 15 Mar 2021 12:21:16 +0100 Message-Id: <20210315112118.13641-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.188 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 1/3] tools/zip: add missing start_disk field for zip64 extension X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Mon, 15 Mar 2021 11:21:50 -0000 it is not optional, even though we give the size explicitely Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> --- src/tools/zip.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/tools/zip.rs b/src/tools/zip.rs index 1f9ee517..cca2e766 100644 --- a/src/tools/zip.rs +++ b/src/tools/zip.rs @@ -80,6 +80,7 @@ struct Zip64FieldWithOffset { uncompressed_size: u64, compressed_size: u64, offset: u64, + start_disk: u32, } #[derive(Endian)] @@ -334,10 +335,11 @@ impl ZipEntry { &mut buf, Zip64FieldWithOffset { field_type: 1, - field_size: 3 * 8, + field_size: 3 * 8 + 4, uncompressed_size: self.uncompressed_size, compressed_size: self.compressed_size, offset: self.offset, + start_disk: 0, }, ) .await?; -- 2.20.1