From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <d.csapak@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id ADB3269D6B for <pbs-devel@lists.proxmox.com>; Thu, 25 Feb 2021 10:01:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AA7F431F14 for <pbs-devel@lists.proxmox.com>; Thu, 25 Feb 2021 10:01:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A074631F02 for <pbs-devel@lists.proxmox.com>; Thu, 25 Feb 2021 10:01:24 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6C5C94615D for <pbs-devel@lists.proxmox.com>; Thu, 25 Feb 2021 10:01:24 +0100 (CET) From: Dominik Csapak <d.csapak@proxmox.com> To: pbs-devel@lists.proxmox.com Date: Thu, 25 Feb 2021 10:01:22 +0100 Message-Id: <20210225090122.1094-5-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210225090122.1094-1-d.csapak@proxmox.com> References: <20210225090122.1094-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.206 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup v2 4/4] ui: LoginView: show webauthn errors in window X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 25 Feb 2021 09:01:25 -0000 instead of silently discarding the error, else the user might be confused because nothing happened Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> --- www/LoginView.js | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/www/LoginView.js b/www/LoginView.js index 1c7a977c..6dd09646 100644 --- a/www/LoginView.js +++ b/www/LoginView.js @@ -383,6 +383,7 @@ Ext.define('PBS.login.TfaWindow', { let view = me.getView(); me.lookup('webAuthnWaiting').setVisible(true); + me.lookup('webAuthnError').setVisible(false); let challenge = view.challenge.webauthn; @@ -409,6 +410,10 @@ Ext.define('PBS.login.TfaWindow', { // checking for error.code === DOMException.ABORT_ERR only works in firefox -.- this.getViewModel().set('canConfirm', true); // FIXME: better handling, show some message, ...? + me.lookup('webAuthnError').setData({ + error: Ext.htmlEncode(error.toString()), + }); + me.lookup('webAuthnError').setVisible(true); return; } finally { let waitingMessage = me.lookup('webAuthnWaiting'); @@ -505,6 +510,15 @@ Ext.define('PBS.login.TfaWindow', { reference: 'webAuthnWaiting', hidden: true, }, + { + xtype: 'box', + data: { + error: '', + }, + tpl: '<i class="fa fa-warning warning"></i> {error}', + reference: 'webAuthnError', + hidden: true, + }, ], }, { -- 2.20.1