From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6BD6262F14 for ; Mon, 8 Feb 2021 15:26:08 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 69B6D237F1 for ; Mon, 8 Feb 2021 15:26:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0403E237E7 for ; Mon, 8 Feb 2021 15:26:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C024245055 for ; Mon, 8 Feb 2021 15:26:07 +0100 (CET) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Mon, 8 Feb 2021 15:26:03 +0100 Message-Id: <20210208142603.24149-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.004 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server] test: migrate: correctly mock storage module X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Feb 2021 14:26:08 -0000 by fixing a typo. Since cfs_read_file within the storage module was not mocked, the tests could fail on some setups. Now that get_bandwidth_limit is mocked, cfs_read_file is not called anymore, but still mock it too for good measure and to make it more future-proof. Reported-by: Fabian Grünbichler Signed-off-by: Fabian Ebner --- test/MigrationTest/Shared.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/MigrationTest/Shared.pm b/test/MigrationTest/Shared.pm index d7aeb36..6552465 100644 --- a/test/MigrationTest/Shared.pm +++ b/test/MigrationTest/Shared.pm @@ -140,9 +140,10 @@ $storage_module->mock( config => sub { return $storage_config; }, - get_bandwitdth_limit => sub { + get_bandwidth_limit => sub { return 123456; }, + cfs_read_file => $mocked_cfs_read_file, ); our $storage_plugin_module = Test::MockModule->new("PVE::Storage::Plugin"); -- 2.20.1