From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <s.reiter@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id C0BA16D152
for <pve-devel@lists.proxmox.com>; Thu, 4 Feb 2021 13:52:34 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id B280623FD5
for <pve-devel@lists.proxmox.com>; Thu, 4 Feb 2021 13:52:34 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[212.186.127.180])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id 8702723FF6
for <pve-devel@lists.proxmox.com>; Thu, 4 Feb 2021 13:52:33 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 532AD461EB
for <pve-devel@lists.proxmox.com>; Thu, 4 Feb 2021 13:52:33 +0100 (CET)
From: Stefan Reiter <s.reiter@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Thu, 4 Feb 2021 13:52:22 +0100
Message-Id: <20210204125224.25059-2-s.reiter@proxmox.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20210204125224.25059-1-s.reiter@proxmox.com>
References: <20210204125224.25059-1-s.reiter@proxmox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.037 Adjusted score from AWL reputation of From: address
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/,
medium trust
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [qemuconfig.pm]
Subject: [pve-devel] [PATCH qemu-server 2/4] savevm: periodically print
progress
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 04 Feb 2021 12:52:34 -0000
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
---
PVE/QemuConfig.pm | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm
index 3f4605f..37db347 100644
--- a/PVE/QemuConfig.pm
+++ b/PVE/QemuConfig.pm
@@ -14,6 +14,7 @@ use PVE::QemuServer;
use PVE::QemuServer::Machine;
use PVE::Storage;
use PVE::Tools;
+use PVE::CLIFormatter;
use base qw(PVE::AbstractConfig);
@@ -280,14 +281,26 @@ sub __snapshot_create_vol_snapshots_hook {
PVE::Storage::activate_volumes($storecfg, [$snap->{vmstate}]);
mon_cmd($vmid, "savevm-start", statefile => $path);
+ print "saving VM state and RAM\n";
+ my $start = time();
+ my $state = sub {
+ my ($bytes) = @_;
+ my $b = PVE::CLIFormatter::render_bytes($bytes);
+ my $t = PVE::CLIFormatter::render_duration(time() - $start);
+ return "$b in $t";
+ };
for(;;) {
my $stat = mon_cmd($vmid, "query-savevm");
if (!$stat->{status}) {
die "savevm not active\n";
} elsif ($stat->{status} eq 'active') {
sleep(1);
+ my $s = $state->($stat->{bytes});
+ print "progress: $s\n";
next;
} elsif ($stat->{status} eq 'completed') {
+ my $s = $state->($stat->{bytes});
+ print "saved $s\n";
last;
} else {
die "query-savevm returned status '$stat->{status}'\n";
--
2.20.1