From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <root@dev.dominic.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 7EE6D6989D
for <pbs-devel@lists.proxmox.com>; Tue, 19 Jan 2021 12:09:56 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 6FAC31D535
for <pbs-devel@lists.proxmox.com>; Tue, 19 Jan 2021 12:09:26 +0100 (CET)
Received: from dev.dominic.proxmox.com (212-186-127-178.static.upcbusiness.at
[212.186.127.178])
by firstgate.proxmox.com (Proxmox) with ESMTP id 3F42C1D503
for <pbs-devel@lists.proxmox.com>; Tue, 19 Jan 2021 12:09:25 +0100 (CET)
Received: by dev.dominic.proxmox.com (Postfix, from userid 0)
id 21CF2223AE; Tue, 19 Jan 2021 12:09:25 +0100 (CET)
From: =?UTF-8?q?Dominic=20J=C3=A4ger?= <d.jaeger@proxmox.com>
To: pbs-devel@lists.proxmox.com
Date: Tue, 19 Jan 2021 12:09:14 +0100
Message-Id: <20210119110915.18864-4-d.jaeger@proxmox.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20210119110915.18864-1-d.jaeger@proxmox.com>
References: <20210119110915.18864-1-d.jaeger@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 1
AWL -0.361 Adjusted score from AWL reputation of From: address
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery
methods
KHOP_HELO_FCRDNS 0.398 Relay HELO differs from its IP's reverse DNS
NO_DNS_FOR_FROM 0.379 Envelope sender has no MX or A DNS records
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_NONE 0.001 SPF: sender does not publish an SPF Record
Subject: [pbs-devel] [PATCH proxmox-backup 3/4] ui: remote edit: Error as
symbol to the right
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 19 Jan 2021 11:09:56 -0000
On error, a symbol appears to the right of the textfield.
Then every error message appears there.
This way users can
1. Hover over the error symbol to read the error message
2. Hover over the label or the field to see the regular tooltip
So this avoids the problem, that the error message hides the regular tooltip
when users hover over the textfield.
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
---
www/window/RemoteEdit.js | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/www/window/RemoteEdit.js b/www/window/RemoteEdit.js
index 391b10bc..7fb3a952 100644
--- a/www/window/RemoteEdit.js
+++ b/www/window/RemoteEdit.js
@@ -40,6 +40,7 @@ Ext.define('PBS.window.RemoteEdit', {
cbind: {
editable: '{isCreate}',
},
+ msgTarget: 'side',
autoEl: {
tag: 'div',
'data-qtip': gettext('A unique name to identify this remote.'),
@@ -53,6 +54,7 @@ Ext.define('PBS.window.RemoteEdit', {
submitValue: false,
vtype: 'HostPort',
fieldLabel: gettext('Host'),
+ msgTarget: 'side',
autoEl: {
tag: 'div',
'data-qtip': gettext('The DNS or IP address of the remote, optionally with a port.'),
@@ -104,6 +106,7 @@ Ext.define('PBS.window.RemoteEdit', {
afterLabelTextTpl: " *",
name: 'auth-id',
fieldLabel: gettext('Auth ID'),
+ msgTarget: 'side',
autoEl: {
tag: 'div',
'data-qtip': gettext('For example: admin@pbs.'),
@@ -114,6 +117,7 @@ Ext.define('PBS.window.RemoteEdit', {
inputType: 'password',
fieldLabel: gettext('Password'),
name: 'password',
+ msgTarget: 'side',
cbind: {
emptyText: '{passwordEmptyText}',
allowBlank: '{!isCreate}',
--
2.20.1