From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <o.bektas@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3D8A167D92 for <pve-devel@lists.proxmox.com>; Tue, 10 Nov 2020 15:33:30 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 326FA23919 for <pve-devel@lists.proxmox.com>; Tue, 10 Nov 2020 15:33:30 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 96B172390D for <pve-devel@lists.proxmox.com>; Tue, 10 Nov 2020 15:33:28 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5A61846059 for <pve-devel@lists.proxmox.com>; Tue, 10 Nov 2020 15:33:28 +0100 (CET) Date: Tue, 10 Nov 2020 15:33:18 +0100 From: Oguz Bektas <o.bektas@proxmox.com> To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Message-ID: <20201110143318.GA8960@gaia.proxmox.com> Mail-Followup-To: Oguz Bektas <o.bektas@proxmox.com>, Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <20201110141530.30904-1-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201110141530.30904-1-s.ivanov@proxmox.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-SPAM-LEVEL: Spam detection results: 0 AWL 1.480 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH installer 0/3] memorize keyboard layout and run setupcon in background X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 10 Nov 2020 14:33:30 -0000 ACK from me, fixes the described issue and keeps the chosen layout. Tested-by: Oguz Bektas <o.bektas@proxmox.com> On Tue, Nov 10, 2020 at 03:15:27PM +0100, Stoiko Ivanov wrote: > This patchset addresses the issue found by Oguz with setupcon slowing down the > GUI. > > After some discussion off-list with Thomas and Oguz 2 thinks were considered > worth improving: > * memorize the chosen keyboard layout and don't jump back to the one defined > by the country - when using the Previous/Next buttons > * still set the keymap of the installer system, but do it in the background > > I tested the patches locally and think they work as they should (but then again > the possible combinations of changed country/changed keymap/freshly drawn > window confused me a bit - so would be grateful for some testing) > > > Stoiko Ivanov (3): > memorize keyboard layout selection > add run_in_background > set the keymap on the installer console > > proxinstall | 52 +++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 51 insertions(+), 1 deletion(-) > > -- > 2.20.1 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > >