From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <f.ebner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 4A74F601AD
for <pve-devel@lists.proxmox.com>; Wed, 14 Oct 2020 13:36:35 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 3F9F58E78
for <pve-devel@lists.proxmox.com>; Wed, 14 Oct 2020 13:36:35 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[212.186.127.180])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id 5C5AB8E5D
for <pve-devel@lists.proxmox.com>; Wed, 14 Oct 2020 13:36:34 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2145345D5C
for <pve-devel@lists.proxmox.com>; Wed, 14 Oct 2020 13:36:34 +0200 (CEST)
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Wed, 14 Oct 2020 13:36:27 +0200
Message-Id: <20201014113628.14286-5-f.ebner@proxmox.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20201014113628.14286-1-f.ebner@proxmox.com>
References: <20201014113628.14286-1-f.ebner@proxmox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.046 Adjusted score from AWL reputation of From: address
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/,
medium trust
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [replicationconfig.pm]
Subject: [pve-devel] [PATCH guest-common 4/5] remove the now unused
remove_vmid_jobs
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 14 Oct 2020 11:36:35 -0000
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
I *think* that I have all the repositiories where this would
potentially be used, but please double check that there are
no users of this anywhere.
PVE/ReplicationConfig.pm | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/PVE/ReplicationConfig.pm b/PVE/ReplicationConfig.pm
index 77905a0..a220594 100644
--- a/PVE/ReplicationConfig.pm
+++ b/PVE/ReplicationConfig.pm
@@ -265,20 +265,6 @@ sub delete_job {
lock($code);
}
-sub remove_vmid_jobs {
- my ($vmid) = @_;
-
- my $code = sub {
- my $cfg = __PACKAGE__->new();
- foreach my $id (keys %{$cfg->{ids}}) {
- delete $cfg->{ids}->{$id} if ($cfg->{ids}->{$id}->{guest} == $vmid);
- }
- $cfg->write();
- };
-
- lock($code);
-}
-
sub swap_source_target_nolock {
my ($jobid) = @_;
--
2.20.1