From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <root@dev.dominic.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id DE6886427C
for <pbs-devel@lists.proxmox.com>; Tue, 6 Oct 2020 12:10:46 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id D7F9E24313
for <pbs-devel@lists.proxmox.com>; Tue, 6 Oct 2020 12:10:46 +0200 (CEST)
Received: from dev.dominic.proxmox.com (212-186-127-178.static.upcbusiness.at
[212.186.127.178])
by firstgate.proxmox.com (Proxmox) with ESMTP id 5E15424309
for <pbs-devel@lists.proxmox.com>; Tue, 6 Oct 2020 12:10:46 +0200 (CEST)
Received: by dev.dominic.proxmox.com (Postfix, from userid 0)
id 375F0204DF; Tue, 6 Oct 2020 12:10:46 +0200 (CEST)
From: =?UTF-8?q?Dominic=20J=C3=A4ger?= <d.jaeger@proxmox.com>
To: pbs-devel@lists.proxmox.com
Date: Tue, 6 Oct 2020 12:10:00 +0200
Message-Id: <20201006101000.70009-1-d.jaeger@proxmox.com>
X-Mailer: git-send-email 2.20.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 1
AWL -0.536 Adjusted score from AWL reputation of From: address
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery
methods
KHOP_HELO_FCRDNS 0.398 Relay HELO differs from its IP's reverse DNS
NO_DNS_FOR_FROM 0.379 Envelope sender has no MX or A DNS records
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_NONE 0.001 SPF: sender does not publish an SPF Record
Subject: [pbs-devel] [PATCH proxmox-backup] Close #3058: ui: RemoteEdit: Add
empty texts
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 06 Oct 2020 10:10:46 -0000
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
---
www/window/RemoteEdit.js | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/www/window/RemoteEdit.js b/www/window/RemoteEdit.js
index 56a248e0..695ad422 100644
--- a/www/window/RemoteEdit.js
+++ b/www/window/RemoteEdit.js
@@ -24,7 +24,7 @@ Ext.define('PBS.window.RemoteEdit', {
me.method = name ? 'PUT' : 'POST';
me.autoLoad = !!name;
return {
- passwordEmptyText: me.isCreate ? '' : gettext('Unchanged'),
+ passwordEmptyText: me.isCreate ? '•'.repeat(16) : gettext('Unchanged'),
};
},
@@ -35,6 +35,7 @@ Ext.define('PBS.window.RemoteEdit', {
xtype: 'pmxDisplayEditField',
name: 'name',
fieldLabel: gettext('Remote'),
+ emptyText: 'new_remote',
renderer: Ext.htmlEncode,
allowBlank: false,
minLength: 4,
@@ -49,6 +50,7 @@ Ext.define('PBS.window.RemoteEdit', {
submitValue: false,
vtype: 'HostPort',
fieldLabel: gettext('Host'),
+ emptyText: '192.168.10.10',
listeners: {
change: function(field, newvalue) {
let host = newvalue;
@@ -95,6 +97,7 @@ Ext.define('PBS.window.RemoteEdit', {
allowBlank: false,
name: 'userid',
fieldLabel: gettext('Userid'),
+ emptyText: 'root@pam',
},
{
xtype: 'textfield',
@@ -116,6 +119,7 @@ Ext.define('PBS.window.RemoteEdit', {
deleteEmpty: '{!isCreate}',
},
fieldLabel: gettext('Fingerprint'),
+ emptyText: '0f:04:9a:2d:48:23:52:5d:d5:f4:1d:9e:5d:37:8e:60:93:d8:b0:03:31:8c:5c:d5:49:ff:96:31:9e:c2:1d:74',
},
{
xtype: 'proxmoxtextfield',
@@ -124,6 +128,7 @@ Ext.define('PBS.window.RemoteEdit', {
deleteEmpty: '{!isCreate}',
},
fieldLabel: gettext('Comment'),
+ emptyText: gettext('A very long comment'),
},
],
},
--
2.20.1