From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <s.ivanov@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id B7507623D1;
 Wed, 16 Sep 2020 14:15:06 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id B1A6923B0B;
 Wed, 16 Sep 2020 14:14:36 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 9B18723B01;
 Wed, 16 Sep 2020 14:14:35 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 53918453E2;
 Wed, 16 Sep 2020 14:14:35 +0200 (CEST)
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com,
	pbs-devel@lists.proxmox.com
Date: Wed, 16 Sep 2020 14:14:16 +0200
Message-Id: <20200916121419.3997-1-s.ivanov@proxmox.com>
X-Mailer: git-send-email 2.20.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.014 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [zfs.rs, proxmox.com, zfs.pm]
Subject: [pve-devel] [RFC proxmox-backup/storage/zfsonlinux] improve zpool
 import for freshly created zpools
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 16 Sep 2020 12:15:06 -0000

The issue of created zpools not being imported on boot, due to a
missing/partial/corrupt zpool.cache file is something which we see quite often
reported in our various support-channels.

With PVE the issue was mitigated (and it did not show up so often), since
pvestatd does activate all storages (which imports all referenced zpools).

This does not hold for proxmox-backup (see the thread in our community forum
[0]).

After a short off-list discussion with Fabian (G.) the following patchset
addresses the issue by adding 'zpool-import@.service' to our zfsonlinux repo
and instantiating the template unit in the API paths where we create
zpools (for storages or datastores)

quickly tested on testsetups of mine (by adding a pool and then checking
when it got imported according to the journal).


[0]: https://forum.proxmox.com/threads/pbs-chunks-error-after-update.75467/

zfsonlinux:
Stoiko Ivanov (1):
  Add systemd-unit for importing specific pools

 ...md-unit-for-importing-specific-pools.patch | 75 +++++++++++++++++++
 debian/patches/series                         |  1 +
 debian/zfsutils-linux.install                 |  1 +
 3 files changed, 77 insertions(+)
 create mode 100644 debian/patches/0008-Add-systemd-unit-for-importing-specific-pools.patch

proxmox-backup:
Stoiko Ivanov (1):
  api2/node/disks/zfs: instantiate import service

 src/api2/node/disks/zfs.rs | 5 +++++
 1 file changed, 5 insertions(+)

pve-storage:
Stoiko Ivanov (1):
  Disks: instantiate import unit for created zpool

 PVE/API2/Disks/ZFS.pm | 6 ++++++
 1 file changed, 6 insertions(+)

-- 
2.20.1





From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <s.ivanov@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id B7507623D1;
 Wed, 16 Sep 2020 14:15:06 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id B1A6923B0B;
 Wed, 16 Sep 2020 14:14:36 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 9B18723B01;
 Wed, 16 Sep 2020 14:14:35 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 53918453E2;
 Wed, 16 Sep 2020 14:14:35 +0200 (CEST)
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com,
	pbs-devel@lists.proxmox.com
Date: Wed, 16 Sep 2020 14:14:16 +0200
Message-Id: <20200916121419.3997-1-s.ivanov@proxmox.com>
X-Mailer: git-send-email 2.20.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.014 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [zfs.rs, proxmox.com, zfs.pm]
Subject: [pbs-devel] [RFC proxmox-backup/storage/zfsonlinux] improve zpool
 import for freshly created zpools
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 16 Sep 2020 12:15:06 -0000

The issue of created zpools not being imported on boot, due to a
missing/partial/corrupt zpool.cache file is something which we see quite often
reported in our various support-channels.

With PVE the issue was mitigated (and it did not show up so often), since
pvestatd does activate all storages (which imports all referenced zpools).

This does not hold for proxmox-backup (see the thread in our community forum
[0]).

After a short off-list discussion with Fabian (G.) the following patchset
addresses the issue by adding 'zpool-import@.service' to our zfsonlinux repo
and instantiating the template unit in the API paths where we create
zpools (for storages or datastores)

quickly tested on testsetups of mine (by adding a pool and then checking
when it got imported according to the journal).


[0]: https://forum.proxmox.com/threads/pbs-chunks-error-after-update.75467/

zfsonlinux:
Stoiko Ivanov (1):
  Add systemd-unit for importing specific pools

 ...md-unit-for-importing-specific-pools.patch | 75 +++++++++++++++++++
 debian/patches/series                         |  1 +
 debian/zfsutils-linux.install                 |  1 +
 3 files changed, 77 insertions(+)
 create mode 100644 debian/patches/0008-Add-systemd-unit-for-importing-specific-pools.patch

proxmox-backup:
Stoiko Ivanov (1):
  api2/node/disks/zfs: instantiate import service

 src/api2/node/disks/zfs.rs | 5 +++++
 1 file changed, 5 insertions(+)

pve-storage:
Stoiko Ivanov (1):
  Disks: instantiate import unit for created zpool

 PVE/API2/Disks/ZFS.pm | 6 ++++++
 1 file changed, 6 insertions(+)

-- 
2.20.1