From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dcsapak@zita.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B6BC76114C for <pbs-devel@lists.proxmox.com>; Fri, 4 Sep 2020 14:34:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7FCFD20CE4 for <pbs-devel@lists.proxmox.com>; Fri, 4 Sep 2020 14:33:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E395820C7F for <pbs-devel@lists.proxmox.com>; Fri, 4 Sep 2020 14:33:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A7B0944A17 for <pbs-devel@lists.proxmox.com>; Fri, 4 Sep 2020 14:33:36 +0200 (CEST) From: Dominik Csapak <d.csapak@proxmox.com> To: pbs-devel@lists.proxmox.com Date: Fri, 4 Sep 2020 14:33:33 +0200 Message-Id: <20200904123334.3731-11-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200904123334.3731-1-d.csapak@proxmox.com> References: <20200904123334.3731-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.090 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods NO_DNS_FOR_FROM 0.379 Envelope sender has no MX or A DNS records RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [time.rs] Subject: [pbs-devel] [PATCH proxmox-backup v2 10/11] tools/systemd/time: fix signed conversion X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 04 Sep 2020 12:34:11 -0000 instead of using 'as' and silently converting wrong, use the TryInto trait and raise an error if we cannot convert this should only happen if we have a negative year, but this is expected (we do not want schedules from before the year 0) Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> --- src/tools/systemd/time.rs | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src/tools/systemd/time.rs b/src/tools/systemd/time.rs index 69f5f5fb..7717ecee 100644 --- a/src/tools/systemd/time.rs +++ b/src/tools/systemd/time.rs @@ -1,3 +1,5 @@ +use std::convert::TryInto; + use anyhow::Error; use bitflags::bitflags; @@ -174,17 +176,17 @@ pub fn compute_next_event( } if !all_days { // match day first - let day_num = t.day_num(); + let day_num: u32 = t.day_num().try_into()?; let day = WeekDays::from_bits(1<<day_num).unwrap(); if !event.days.contains(day) { if let Some(n) = ((day_num+1)..7) .find(|d| event.days.contains(WeekDays::from_bits(1<<d).unwrap())) { // try next day - t.add_days(n - day_num,)?; + t.add_days((n - day_num).try_into()?)?; } else { // try next week - t.add_days(7 - day_num)?; + t.add_days((7 - day_num).try_into()?)?; } continue; } @@ -192,11 +194,11 @@ pub fn compute_next_event( // this day if !event.hour.is_empty() { - let hour = t.hour() as u32; + let hour = t.hour().try_into()?; if !DateTimeValue::list_contains(&event.hour, hour) { if let Some(n) = DateTimeValue::find_next(&event.hour, hour) { // test next hour - t.set_time(n as libc::c_int, 0, 0)?; + t.set_time(n.try_into()?, 0, 0)?; } else { // test next day t.add_days(1)?; @@ -207,11 +209,11 @@ pub fn compute_next_event( // this hour if !event.minute.is_empty() { - let minute = t.min() as u32; + let minute = t.min().try_into()?; if !DateTimeValue::list_contains(&event.minute, minute) { if let Some(n) = DateTimeValue::find_next(&event.minute, minute) { // test next minute - t.set_min_sec(n as libc::c_int, 0)?; + t.set_min_sec(n.try_into()?, 0)?; } else { // test next hour t.set_time(t.hour() + 1, 0, 0)?; @@ -222,11 +224,11 @@ pub fn compute_next_event( // this minute if !event.second.is_empty() { - let second = t.sec() as u32; + let second = t.sec().try_into()?; if !DateTimeValue::list_contains(&event.second, second) { if let Some(n) = DateTimeValue::find_next(&event.second, second) { // test next second - t.set_sec(n as libc::c_int)?; + t.set_sec(n.try_into()?)?; } else { // test next min t.set_min_sec(t.min() + 1, 0)?; -- 2.20.1