From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <s.reiter@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1CA3167044 for <pbs-devel@lists.proxmox.com>; Wed, 29 Jul 2020 14:33:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BCF60E9E8 for <pbs-devel@lists.proxmox.com>; Wed, 29 Jul 2020 14:33:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D98D8E9A7 for <pbs-devel@lists.proxmox.com>; Wed, 29 Jul 2020 14:33:21 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A0AEA433D5 for <pbs-devel@lists.proxmox.com>; Wed, 29 Jul 2020 14:33:21 +0200 (CEST) From: Stefan Reiter <s.reiter@proxmox.com> To: pbs-devel@lists.proxmox.com Date: Wed, 29 Jul 2020 14:33:09 +0200 Message-Id: <20200729123314.10049-1-s.reiter@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.041 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [environment.rs, prune.rs, proxmox-backup-proxy.rs, backup.rs, datastore.rs, pull.rs, tools.rs] Subject: [pbs-devel] [PATCH 0/5] fix #2881: protect base snapshots and avoid races X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 29 Jul 2020 12:33:24 -0000 Avoid races with GC and between different concurrent backups by limiting the number of concurrent backups per group to 1 and forbidding the deletion of the previous finished backup, if a new one is currently running. Fixes several issues that could lead to failed backups, or even worse, "successful" backups that were really missing chunks. proxmox-backup: Stefan Reiter (5): fix typo: avgerage to average datastore: prevent deletion of snaps in use as "previous backup" tools: add nonblocking mode to lock_file backup: use flock on backup group to forbid multiple backups at once backup: ensure base snapshots are still available after backup src/api2/admin/datastore.rs | 4 +-- src/api2/backup.rs | 12 +++++--- src/api2/backup/environment.rs | 23 +++++++++++++-- src/backup/backup_info.rs | 51 ++++++++++++++++++++++++++++++++- src/backup/datastore.rs | 43 +++++++++++++++++++++++++-- src/backup/prune.rs | 2 +- src/bin/proxmox-backup-proxy.rs | 2 +- src/client/backup_writer.rs | 2 +- src/client/pull.rs | 4 +-- src/tools.rs | 13 +++++++++ 10 files changed, 140 insertions(+), 16 deletions(-) -- 2.20.1