From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <a.lauterer@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F3AF85B5AB for <pve-devel@pve.proxmox.com>; Tue, 7 Jul 2020 11:56:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EB52D263BA for <pve-devel@pve.proxmox.com>; Tue, 7 Jul 2020 11:56:23 +0200 (CEST) Received-SPF: pass (proxmox.com: 212.186.127.180 is authorized to use 'a.lauterer@proxmox.com' in 'mfrom' identity (mechanism 'mx' matched)) receiver=firstgate.proxmox.com; identity=mailfrom; envelope-from="a.lauterer@proxmox.com"; helo=proxmox-new.maurer-it.com; client-ip=212.186.127.180 Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id DEC5A26396 for <pve-devel@pve.proxmox.com>; Tue, 7 Jul 2020 11:56:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 379054449B for <pve-devel@pve.proxmox.com>; Tue, 7 Jul 2020 11:49:03 +0200 (CEST) From: Aaron Lauterer <a.lauterer@proxmox.com> To: pve-devel@pve.proxmox.com Date: Tue, 7 Jul 2020 11:48:57 +0200 Message-Id: <20200707094902.24712-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [backup.pm, backupinfo.pm, cluster.pm] X-Mailman-Approved-At: Tue, 07 Jul 2020 12:27:43 +0200 Subject: [pve-devel] [PATCH v4 manager 0/5] add backup detail and not backed up view X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: PVE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 07 Jul 2020 09:56:54 -0000 This series add a new detail view for backup jobs to show which volumes of a guest would be included. Additionally it adds a notification if there are any guests not covered by any backup job with a new window showing these guests. This is to fix #2609. For the latter, a new API endpoint was needed because the already existing `cluster/backup` expects a job ID on the next level. This makes it hard to impossible to add other endpoints there. More details are in the actual patch. Changes from v3 -> v4: * switched from summary view with its own button to notification if some guests are not backed up and changed the view to only include not backed up guests. * added search boxes to both the detail tree view * removed the "not permissions for all" notification. We don't do that anywhere else anyway and it makes the API return structure simpler and easier to deal with * incorporated some code style changes such as creating the object to be pushed to the result array inline in the push operation instead of defining it way before Aaron Lauterer (5): api: backup: add endpoint to list included guests and volumes gui: dc/backup: move renderers to Utils.js gui: dc/backup: add new backup job detail view fix #2609 api: backupinfo: add non job specific endpoint fix #2609 gui: backup: add window for not backed guests PVE/API2/Backup.pm | 174 ++++++++++++ PVE/API2/BackupInfo.pm | 145 ++++++++++ PVE/API2/Cluster.pm | 6 + PVE/API2/Makefile | 1 + www/manager6/Utils.js | 94 +++++++ www/manager6/dc/Backup.js | 574 ++++++++++++++++++++++++++++++++++---- 6 files changed, 936 insertions(+), 58 deletions(-) create mode 100644 PVE/API2/BackupInfo.pm -- 2.20.1