From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C7A281FF17C for ; Wed, 17 Sep 2025 10:05:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AE3E2233F9; Wed, 17 Sep 2025 10:05:37 +0200 (CEST) Message-ID: <1f64b52c-b45c-44b6-adcd-6681b457bf9c@proxmox.com> Date: Wed, 17 Sep 2025 10:05:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Shan Shaji References: <20250904100956.79194-1-s.shaji@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20250904100956.79194-1-s.shaji@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758096295566 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH proxmox_dart_api_client/pve_flutter_frontend v2 0/3] fix: android: add support to honor user installed certificate X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 9/4/25 12:09 PM, Shan Shaji wrote: > The app was not honoring the user installed certificate and was still > throwing `HandShakeException` when using `IOClient`. Inorder to fix the > issue used the `cronet_http` package. This patch series only includes > the changes specific to android. > > changes since v1: https://lore.proxmox.com/pve-devel/DCJ4ONVHUS1B.2PR9TS3ZF3OE4@proxmox.com/T/#t > - Update the commit message with more details and links > - fixed package name not correct in the commit message. > > pve_flutter_frontend: > > Shan Shaji (1): > fix: android: add network config to support custom certificates > > android/app/src/main/AndroidManifest.xml | 3 ++- > android/app/src/main/res/xml/network_security_config.xml | 9 +++++++++ > 2 files changed, 11 insertions(+), 1 deletion(-) > create mode 100644 android/app/src/main/res/xml/network_security_config.xml > > > proxmox_dart_api_client: > > Shan Shaji (2): > fix: android: use `cronet_http` package to honor custom certificates > fix: add explicit throw of `HandShakeException` > > lib/src/authenticate.dart | 31 ++++++++++---- > lib/src/utils_native.dart | 12 ++++++ > pubspec.lock | 89 ++++++++++++++++++++++++++++++++++++--- > pubspec.yaml | 1 + > 4 files changed, 117 insertions(+), 16 deletions(-) > > > Summary over all repositories: > 6 files changed, 128 insertions(+), 17 deletions(-) > while I'm a bit irritated how the dart/flutter devs handle this (why not fix these issues in the dart std library instead of publishing seperate platform specific packages... urgh) this is a "core" package of the dart devs, so it should be good to use here. We can always revert it if we decide to not want to rely on an "external" library. applied, thanks! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel