From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <d.whyte@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 51BC075A1C
 for <pve-devel@lists.proxmox.com>; Thu, 22 Apr 2021 12:31:57 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 4F6731A91B
 for <pve-devel@lists.proxmox.com>; Thu, 22 Apr 2021 12:31:57 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id C75E31A90E
 for <pve-devel@lists.proxmox.com>; Thu, 22 Apr 2021 12:31:56 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9746045BC3
 for <pve-devel@lists.proxmox.com>; Thu, 22 Apr 2021 12:31:56 +0200 (CEST)
To: Stefan Reiter <s.reiter@proxmox.com>, pve-devel@lists.proxmox.com
References: <20210422082507.22747-1-s.reiter@proxmox.com>
 <20210422082507.22747-2-s.reiter@proxmox.com>
From: Dylan Whyte <d.whyte@proxmox.com>
Message-ID: <1e44601c-bc3d-6bbc-2f75-827e44ceb76e@proxmox.com>
Date: Thu, 22 Apr 2021 12:31:55 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <20210422082507.22747-2-s.reiter@proxmox.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.000 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.001 Looks like a legit reply (A)
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH docs 2/2] vzdump: add section about single
 file restore
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 22 Apr 2021 10:31:57 -0000

Hi,

Have even less notes for this one. Just some little things sounded off 
to me.

Reviewed-by: Dylan Whyte <d.whyte@proxmox.com>

On 4/22/21 10:25 AM, Stefan Reiter wrote:
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
>   vzdump.adoc | 24 ++++++++++++++++++++++++
>   1 file changed, 24 insertions(+)
>
> diff --git a/vzdump.adoc b/vzdump.adoc
> index 0577a97..c6063ad 100644
> --- a/vzdump.adoc
> +++ b/vzdump.adoc
> @@ -365,6 +365,30 @@ amount of data is required for initial operation, e.g. web servers - once the OS
>   and necessary services are started, the VM is already operational, while the
>   background task keeps copying seldomly used data.
>   
> +Single File Restore
> +~~~~~~~~~~~~~~~~~~~
> +
> +The 'File Restore' button in the 'Backups' tab of the storage GUI can be used to
> +open a file browser directly on the data contained in a backup. This feature
> +is only available for backups on a Proxmox Backup Server.
> +
> +For containers, the first layer of the file tree shows all included 'pxar'
> +archives, which can be opened and browsed freely. For VMs, the first layer shows
> +contained drive images, which can be opened to reveal a list of supported
> +storage technologies found on the drive. In the most basic case, this will be an
> +entry called 'part', representing a partition table, containing entries for each
s/containing/which contains/
> +partition found on the drive. Note that for VMs, not all data might be
> +accessible (unsupported guest file systems, storage technologies, etc...).
> +
> +Files and directories can be downloaded using the 'Download' button, the latter
> +being compressed into a zip archive on the fly.
> +
> +To enable secure access to VM images, which might contain untrusted data, a
> +temporary VM (not visible as a guest) is started. This does not mean that data
> +downloaded from such an archive is inherently safe, but avoids exposing the
s/avoids/it avoids/
> +hypervisor system to danger. The VM will stop itself after a timeout, the entire
s/, the entire/. This entire/
> +process happens transparently from a users point of view.
s/users/user's/
> +
>   [[vzdump_configuration]]
>   Configuration
>   -------------