From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 2D0111FF187 for ; Tue, 2 Dec 2025 00:23:19 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3C1801BA; Tue, 2 Dec 2025 00:23:43 +0100 (CET) Message-ID: <1dec5398-9619-4406-ad30-8506459a5f39@proxmox.com> Date: Tue, 2 Dec 2025 00:23:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox Datacenter Manager development discussion , Dominik Csapak References: <20251128101848.1580111-1-d.csapak@proxmox.com> <20251128101848.1580111-3-d.csapak@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20251128101848.1580111-3-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1764631375999 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH proxmox 2/2] pve api types: add cluster options api call X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" Am 28.11.25 um 11:18 schrieb Dominik Csapak: > so we can get e.g. the datacenter notes. > > The return schema for this is currently not defined and adding it in > pve-manager is rather hard. > > The reason for this is that while we have defined the datacenter config > schema for the update call, the properties are all property-strings. In > the GET call however, we parse these and return a nested object. > > We'd either have to copy the whole schema and make sure it does not > diverge, or find some more elegant way to modify the return schema to That's not really different to now, nothing really protects us from the schema changing and then a type not working for older APIs. As of now, this needs explicit handling either way if anything changes. And if we would add support for understanding this, then it would not get really harder to start tracking different versions of the schema (pve-api-v8.json) and diff them to see what types also need to be generated in a v8 variant, like we plan for the long run, as that's rather unrelated from the actual generation itself. > include the parsed properties (for some properties this even happens > nested, e.g. a list in a property string gets split into an actual > array). Having (optional) support for this would be nice though, and we do have all the info required for that on the PVE side. As not having to do two deserialization steps with two different formats for getting the actual data (json + parse-property-string) can be easily seen as feature. _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel