From: Fiona Ebner <f.ebner@proxmox.com>
To: "Max R. Carrara" <m.carrara@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH qemu-server] api: create disks: use correct volume name for cloudinit on a snapshot-as-volume-chain storage
Date: Fri, 7 Aug 2026 14:17:50 +0200 [thread overview]
Message-ID: <1c3f5fd8-dbad-42af-847a-2016a45085bd@proxmox.com> (raw)
In-Reply-To: <DKIPBGFQLDE0.R11UYN5D9AWW@proxmox.com>
Am 07.08.26 um 2:13 PM schrieb Max R. Carrara:
> On Fri Aug 7, 2026 at 1:59 PM CEST, Fiona Ebner wrote:
>> The pve-storage commit 05032c5 ("fix #7811: storage: lvm: reject
>> allocation on format and volume name mismatch") exposed an issue with
>> handling the name of the cloudinit name on an LVM storage with
>> snapshot-as-volume-chain. The guest layer passes a fixed name for the
>> cloudinit drive, but this does not match what the storage layer needs,
>> because it was missing the .qcow2 extension. Fix the issue by catching
>> that case.
>>
>> This is a stop-gap fix. In the long run, constructing the name should
>> not be done in the guest layer, rather the storage plugin should be
>> queried for a valid name first.
>>
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>> ---
>
> Just gave this a spin and can confirm that it works as expected.
>
> Before applying this patch, the LVM storage w/ SaVC enabled refused the
> cloudinit drive ('does not match requested format "qcow2"') -- with the
> patch applied, the cloudinit drive can be added again without issues.
>
> Unless there's something I have missed, this LGTM. Nice job!
>
> Consider:
>
> Tested-by: Max R. Carrara <m.carrara@proxmox.com>
Thanks for testing! Applied as
[1/1] api: create disks: use correct volume name for cloudinit on a
snapshot-as-volume-chain storage
commit: f869fe838e08499778197ab660516b5e84efad9f
prev parent reply other threads:[~2026-08-07 12:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 11:59 [PATCH qemu-server] api: create disks: use correct volume name for cloudinit on a snapshot-as-volume-chain storage Fiona Ebner
2026-08-07 12:13 ` Max R. Carrara
2026-08-07 12:17 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c3f5fd8-dbad-42af-847a-2016a45085bd@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.