From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E2D6D1FF13B for ; Wed, 20 May 2026 14:54:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8F98F6A74; Wed, 20 May 2026 14:54:04 +0200 (CEST) Message-ID: <19ded4fa-ce27-4ee8-a9d5-9fb2f8c57e53@proxmox.com> Date: Wed, 20 May 2026 14:53:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH pve-manager] ui: cpu flags: make password managers ignore flag radio buttons To: Arthur Bied-Charreton , pve-devel@lists.proxmox.com References: <20260520124601.520864-1-a.bied-charreton@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20260520124601.520864-1-a.bied-charreton@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779281624372 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BP7CAASZPF7FYHZY4MSKRXX5IMJRQFTH X-Message-ID-Hash: BP7CAASZPF7FYHZY4MSKRXX5IMJRQFTH X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: i guess this could be ok if it works, but i really dislike having to add 1 to 2 attributes per passwordmanager... isn't the generic 'autocomplete=off' enough? On 5/20/26 2:45 PM, Arthur Bied-Charreton wrote: > Password manager extensions scan every new element. The flag > selector grid creates hundreds of radio buttons through its > widgetcolumn, causing the extension to peg the CPU while it checks each > one for autofill. > > Mark the radio inputs with autocomplete="off" and the extension-specific > ignore attributes so they are skipped during the scan. > > Signed-off-by: Arthur Bied-Charreton > --- > www/manager6/form/VMCPUFlagSelector.js | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js > index ea20108d..f8d4caad 100644 > --- a/www/manager6/form/VMCPUFlagSelector.js > +++ b/www/manager6/form/VMCPUFlagSelector.js > @@ -263,16 +263,19 @@ Ext.define('PVE.form.VMCPUFlagSelector', { > boxLabelAlign: 'before', > inputValue: '-', > isFormField: false, > + inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', > }, > { > checked: true, > inputValue: '=', > isFormField: false, > + inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', > }, > { > boxLabel: '+', > inputValue: '+', > isFormField: false, > + inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', > }, > ], > },