From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4D7EA1FF173 for ; Mon, 27 Jan 2025 13:18:45 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9A4D229DC1; Mon, 27 Jan 2025 13:18:43 +0100 (CET) Date: Mon, 27 Jan 2025 13:18:09 +0100 (CET) From: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= To: Proxmox VE development discussion Message-ID: <1864670080.9140.1737980289994@webmail.proxmox.com> In-Reply-To: References: <20241108014620.73352-1-severen.redwood@sitehost.co.nz> MIME-Version: 1.0 X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev72 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH cluster v4 1/2] cluster files: add used_vmids.list X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: t.lamprecht@proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" > Severen Redwood via pve-devel hat am 08.11.2024 02:46 CET geschrieben: > Add `/etc/pve/used_vmids.list` to the list of cluster files, which will > be used for recording previously used VM/CT IDs. This is required so > that we can optionally ensure that such IDs are not suggested by the > `/cluster/nextid` API endpoint. this is encroaching bikeshed-territory, but we don't currently use ".list" as an extension in /etc/pve (and I automatically have to think of APT repository files when seeing it ;)). I think a plain "used_vmids" or "used-vmids" would also work? maybe somebody else has an opinion or suggestion? > > Co-authored-by: Daniel Krambrock > Signed-off-by: Severen Redwood > Tested-by: Aaron Lauterer > Reviewed-by: Aaron Lauterer > --- > There are no changes to this patch since v3. > > src/PVE/Cluster.pm | 1 + > src/pmxcfs/status.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm > index f899dbe..059c7af 100644 > --- a/src/PVE/Cluster.pm > +++ b/src/PVE/Cluster.pm > @@ -84,6 +84,7 @@ my $observed = { > 'virtual-guest/profiles.cfg' => 1, > 'mapping/pci.cfg' => 1, > 'mapping/usb.cfg' => 1, > + 'used_vmids.list' => 1, > }; > > sub prepare_observed_file_basedirs { > diff --git a/src/pmxcfs/status.c b/src/pmxcfs/status.c > index dc44464..7f60145 100644 > --- a/src/pmxcfs/status.c > +++ b/src/pmxcfs/status.c > @@ -114,6 +114,7 @@ static memdb_change_t memdb_change_array[] = { > { .path = "firewall/cluster.fw" }, > { .path = "mapping/pci.cfg" }, > { .path = "mapping/usb.cfg" }, > + { .path = "used_vmids.list" }, > }; > > static GMutex mutex; > -- > 2.47.0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel