From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 10E9F1FF141 for ; Mon, 30 Mar 2026 20:28:42 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A218667BA; Mon, 30 Mar 2026 20:29:08 +0200 (CEST) Message-ID: <1827ab00-229f-4e3b-a9d1-82bbe2865e17@proxmox.com> Date: Mon, 30 Mar 2026 20:28:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH] client: support individual repository component parameters To: Maximiliano Sandoval References: <20260323211400.2661765-1-t.lamprecht@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774895260412 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.007 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TZKKQGLBN5VGJI43ZL73Y4N7D2OHHBON X-Message-ID-Hash: TZKKQGLBN5VGJI43ZL73Y4N7D2OHHBON X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pbs-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 24.03.26 um 16:58 schrieb Maximiliano Sandoval: >> +.. Note:: Remember to quote API token identifiers on the shell, since the >> + exclamation mark (``!``) is a special character in most shells > This makes me wonder if there should too be a dedicated --api-token > parameter too (that basically appends `!tokenname` to the user). I ran > into this issue a couple of times in the past, while having it in the > documentation is good, perhaps it is not the first place one would look > for this. Maybe, but that would then need to be adapted also in the user interfaces (PBS remote, PVE storage, PDM remote, maybe others) for consistency. And it probably can be it's own change set, so I did not wanted to think to much about this for the v2 to avoid having it blocked by some additional potential improvement (should be still easier to implement on top of this series, if we decide that we actually want it). >> + >> The web interface provides copyable repository text in the datastore summary >> with the `Show Connection Information` button. >> >> @@ -70,6 +114,22 @@ Environment Variables >> ``PBS_REPOSITORY`` >> The default backup repository. >> >> +``PBS_SERVER`` >> + Default backup server address. Used as a fallback when neither >> + ``--repository`` / ``PBS_REPOSITORY`` nor ``--server`` is given. >> + Requires ``PBS_DATASTORE`` to be set as well. > I am not sure about the use of "default", since one has to specify one > or the other. I would personally say something like: > > Backup server address. Requires to be used in conjunction to --datastore > or PBS_DATASTORE. This option is not compatible with --repository or > PBS_REPOSITORY. ack