From: Fiona Ebner <f.ebner@proxmox.com>
To: Lukas Sichert <l.sichert@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH storage v7 1/4] lvm: saferemove: zero out volumes range by range
Date: Tue, 30 Jun 2026 16:28:50 +0200 [thread overview]
Message-ID: <18119a52-227d-4ceb-9a25-83a4ea3eb9f2@proxmox.com> (raw)
In-Reply-To: <DJMG539MX7J8.25O7YMZEYEE3M@proxmox.com>
Am 30.06.26 um 4:16 PM schrieb Lukas Sichert:
> On 2026-06-30 13:49, Fiona Ebner <f.ebner@proxmox.com> wrote:
>> Am 16.06.26 um 12:12 PM schrieb Lukas Sichert:
>>> + my $err = undef;
>>> + eval { $secure_delete_cmd->($lvmpath); };
>>> + $err = $@ if $@;
>>> +
>>> + if (!$err) {
>>
>> Style nit: you could switch the branches and just write
>> eval { ... };
>> if (my $err = $@) {
>
> Yes, for this patch alone the inverted form would be nicer. I kept the
> separate '$err' variable intentionally because patch 2/4 adds a discard-only
> path that reuses the same error handling. That avoids reshuffling this
> block again in the follow-up patch.
Ah, makes sense :)
next prev parent reply other threads:[~2026-06-30 14:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 10:13 [PATCH docs/manager/storage v7 0/4] fix #7339: lvmthick: add option to free storage for deleted VMs Lukas Sichert
2026-06-16 10:13 ` [PATCH storage v7 1/4] lvm: saferemove: zero out volumes range by range Lukas Sichert
2026-06-30 11:49 ` Fiona Ebner
2026-06-30 14:16 ` Lukas Sichert
2026-06-30 14:28 ` Fiona Ebner [this message]
2026-06-16 10:13 ` [PATCH storage v7 2/4] fix #7339: lvm: add discard action for removed volumes Lukas Sichert
2026-06-30 10:55 ` Michael Köppl
2026-06-30 12:14 ` Fiona Ebner
2026-06-30 12:20 ` Fiona Ebner
2026-06-30 12:37 ` Fiona Ebner
2026-06-16 10:13 ` [PATCH manager v7 3/4] fix #7339: lvmthick: ui: add UI option to free storage Lukas Sichert
2026-06-30 11:38 ` Michael Köppl
2026-06-16 10:13 ` [PATCH docs v7 4/4] fix #7339: lvm: document discard option Lukas Sichert
2026-06-30 11:48 ` Michael Köppl
2026-06-30 12:50 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18119a52-227d-4ceb-9a25-83a4ea3eb9f2@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=l.sichert@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.