all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>,
	Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 4/4] docs: add description for gc-cache-capacity tuning parameter
Date: Fri, 4 Apr 2025 14:37:03 +0200	[thread overview]
Message-ID: <17f3c997-fc1b-47d2-b29b-080f630f1877@proxmox.com> (raw)
In-Reply-To: <725e5a3b-4c3b-49aa-8f37-a13ad331ad99@proxmox.com>

On 4/4/25 14:28, Lukas Wagner wrote:
> 
> 
> On  2025-04-04 14:20, Thomas Lamprecht wrote:
>> Two alternatives:
>> - Changes this to the shift width, i.e. the x from 2^x, similar to the
>>    ZFS setting. Makes it nice small number to configure and for most
>>    use cases the exponential nature should be still granular enough.
>>    That said, it's not very user-friendly, at least to those without
>>    some level of CS background or the like.
>>
>> - just drop the * 1024 factor and allow users to enter the full number,
>>    it then can be simply described as numbers of chunks which is trivial
>>    to understand and relate too.
>>
>> Personally I'd favor the second option, mainly because it's so simple,
>> and having big numbers here is not that of a huge problem.
> 
> Sounds like a good idea, I like it.
> My main gripe with the "times 1024" option was that it makes it a bit
> more confusing to the user (e.g. me, when reading 'GC LRU cache capacity (in multiples of 1024 chunk digests)'
> in the UI I first thought that the value itself must be a multiple of 1024).
> 
> Changing the setting to the full number, we avoid this potential for confusion while
> still giving power-users a good sense of what is going on under the hood.

Okay, so let's go with the full values there, that should be the least 
confusing one.


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  reply	other threads:[~2025-04-04 12:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-03 12:27 [pbs-devel] [PATCH proxmox] pbs api types: add garbage collection cache capacity tuning option Christian Ebner
2025-04-03 12:27 ` [pbs-devel] [PATCH proxmox-backup 2/4] garbage collection: set phase1 LRU cache capacity by " Christian Ebner
2025-04-03 12:27 ` [pbs-devel] [PATCH proxmox-backup 3/4] ui: expose GC cache capacity in datastore tuning parameters Christian Ebner
2025-04-03 12:27 ` [pbs-devel] [PATCH proxmox-backup 4/4] docs: add description for gc-cache-capacity tuning parameter Christian Ebner
2025-04-04 11:58   ` Lukas Wagner
2025-04-04 12:13     ` Christian Ebner
2025-04-04 12:20     ` Thomas Lamprecht
2025-04-04 12:28       ` Lukas Wagner
2025-04-04 12:37         ` Christian Ebner [this message]
2025-04-04 11:59 ` [pbs-devel] [PATCH proxmox] pbs api types: add garbage collection cache capacity tuning option Lukas Wagner
2025-04-04 13:08 ` [pbs-devel] superseded: " Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17f3c997-fc1b-47d2-b29b-080f630f1877@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=l.wagner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal