From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 680571FF146 for ; Tue, 07 Jul 2026 13:06:59 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 725F821441; Tue, 07 Jul 2026 13:06:58 +0200 (CEST) Message-ID: <17edc9ba-5964-4e03-98eb-633b41a1245b@proxmox.com> Date: Tue, 7 Jul 2026 13:06:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH qemu-server v3] fix #7711: pci: try to detect large memory region preconditions To: Fiona Ebner , pve-devel@lists.proxmox.com References: <20260706131036.3583490-1-d.csapak@proxmox.com> <8a406c16-c8d7-4b0f-85a0-02fd75ebcb62@proxmox.com> <7c4756d4-f592-474a-8116-cbbf10b9c690@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783422377873 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.064 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: KYLLVNRXCF2QS2WXEKCYUBICEVF7PHDM X-Message-ID-Hash: KYLLVNRXCF2QS2WXEKCYUBICEVF7PHDM X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 7/7/26 1:01 PM, Fiona Ebner wrote: > Am 07.07.26 um 12:21 PM schrieb Dominik Csapak: >> On 7/7/26 11:11 AM, Fiona Ebner wrote: >>> Am 06.07.26 um 3:10 PM schrieb Dominik Csapak: >>>> +            if (($flags & 0x200) != 0) { >>>> +                # $end is inclusive, so + 1 for the overall size >>>> +                my $size = $end - $start + 1; >>>> +                if ($size > $biggest_size) { >>>> +                    $biggest_size = $size; >>>> +                } >>>> +            } >>>> +        } >>> >>> Should we add an else branch warning about unexpected lines just to be >>> sure? >> >> i'm not convinced we'd gain anything by that. the format of these >> kernel provided sysfs files are rather static, not sure how likely >> it is that this changes > > The issue is that there is no additional fallout/failure later, but the > check would just quietly stop working if it does change for whatever > reason (maybe if they add a new entry at the end?). fair, i'll add a short warning