From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 31C9B1FF0AF for ; Fri, 20 Nov 2026 12:50:49 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 39C00216E8; Fri, 20 Nov 2026 12:50:48 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Lucas Barros Subject: applied: [PATCH common/manager v3 0/2] fix #6357: show all search domains in the node DNS settings Date: Fri, 20 Nov 2026 12:50:36 +0100 Message-ID: <179517543422.4183140.6472884238874649410.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261116133000.6357-0-lucasbarros.kam@gmail.com> References: <20261116133000.6357-0-lucasbarros.kam@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795175443986 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.148 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UPRZQXHJGNJ5NVU36YVUHS6SSHDWT7VH X-Message-ID-Hash: UPRZQXHJGNJ5NVU36YVUHS6SSHDWT7VH X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 16 Nov 2026 10:31:06 -0300, Lucas Barros wrote: > The DNS settings of a node only show the first domain of the 'search' > line of resolv.conf, so saving the dialog again drops the others. > > As suggested by Thomas, v3 keeps the 'resolvconf' parser as it is, as > PVE and PMG use its value to build the FQDN of the node certificate and > more. It adds a new reader that keeps the whole search list, and only > the node DNS API uses it. > > [...] Applied, thanks! [manager] [1/1] fix #6357: api: node dns: return all search domains https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=813a0d644e9fb613191ea0c2b197c06553c0b14a