all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Stefan Hanreich <s.hanreich@proxmox.com>
Subject: Re: [PATCH docs/manager/network/proxmox{,-ve-rs,-firewall} 00/14] sdn: conntrack zones and SNAT for simple zones with a dedicated VRF
Date: Fri, 20 Nov 2026 08:42:41 +0100	[thread overview]
Message-ID: <179515721910.2281522.2727155874470593742.b4-ty@b4> (raw)
In-Reply-To: <20261119194547.674512-1-s.hanreich@proxmox.com>

On Thu, 19 Nov 2026 20:45:32 +0100, Stefan Hanreich wrote:
> The subnets of simple zones with a dedicated VRF may overlap, but all
> VRFs share conntrack zone 0. A connection in one VRF could then match
> the conntrack entry of an identical connection in another VRF, so the
> stateful firewall accepts a new connection as established. Conntrack
> state migration also overwrites the entries of other guests when
> loading entries with identical tuples on the target node. NAT stores
> its mappings in the same conntrack entries, so it is affected as well.
> 
> [...]

Applied, thanks!

Tested on a three-node cluster: SNAT works over a VLAN uplink and over a
VLAN on a bridge, and the same connection in two zones gets two separate
conntrack entries.

What I changed in your patches:
- The conntrack zone map was only filled after the guest table was
  created, so until then guest traffic was tracked in zone 0. It's now
  filled in the same step, and left alone if the SDN config can't be
  read.
- The warnings about conntrack zones and pve-firewall now show up as
  task warnings and only cover zones on the node. Errors of the
  pve-firewall check are no longer hidden.
- I added to the docs where the assigned zone is shown, and later
  reworked the whole VRF section, see my reply to Gabriel.

What I added on top:
With the nftables firewall, TCP over SNAT broke when the uplink was a
VLAN on a bridge, like vmbr0.60. The bridge tracked the replies in zone
0 before they reached the VRF, so they were never translated back. Ping
still worked, which hid the problem at first. The firewall now puts such
bridges and VLAN interfaces into the conntrack zone of the VRF too.
Untagged traffic that only gets its VLAN on the bridge port, and VLAN
interfaces with their own MAC address, are not covered; the docs say so.

Still open:
- A manually created device named like the VRF of a zone still gets
  that zone's conntrack zone on nodes outside the zone.
- The firewall now reads the network links twice per update; once would
  do.

[proxmox]
[01/14] network-api: expose the master device of a link
       commit: e97bb266ac5be664cd7e46fc4aa680fb8cdcab35

[proxmox-firewall]
[06/14] firewall: apply vnet rules to host traffic from vnets in a VRF
       commit: d64d0d9882a228f40ee9a9b664cb86b5055e6faf
[07/14] nftables: expression: add a constructor for map lookups
       commit: c4feaf6825a7376c637ad6f10d93597a11016619
[08/14] nftables: statement: add a helper for setting the conntrack zone
       commit: 58320a92df469baf43869f270b4eda62824ab167
[09/14] nftables: expression: convert the conntrack zones of zone VRFs
       commit: ecb79519bb4459cdab7bb2d17d82e24d4d8cc7cb
[10/14] firewall: add a command applying the conntrack zones of zone VRFs
       commit: 9e9ce8c3750ae6ec4846f0e6a71cf8c3b6f9d997
[11/14] firewall: put guest traffic of zone VRFs into their conntrack zone
       commit: 27c9a0ca6cd7ab967943478ec6c2a9e61027a49d

[proxmox-ve-rs]
[02/14] sdn: config: read the conntrack zone of zones with a dedicated VRF
       commit: 2017aa40a812edcbdf63dc53541452d5dbc21c70
[03/14] sdn: conntrack: map the interfaces of zone VRFs to their conntrack zone
       commit: f2dfb8a9767cacccffbb2f89758d8df7a416c356

[pve-docs]
[14/14] pvesdn: simple zones: document dedicated VRFs
       commit: 8bf67fdb787b04097b9b03215d23928abf5068c3

[pve-manager]
[12/14] network: apply the conntrack zones of zone VRFs
       commit: 1d63ba6a523a35ffb8f6a38155f8247674e5635e
[13/14] network: warn if pve-firewall cannot isolate guests in zone VRFs
       commit: b9c18ff217ba1431321adf1c58da40a37b3b492f

[pve-network]
[04/14] sdn: simple: SNAT via the uplinks of zone VRFs
       commit: a9a035a863ad021055970efe21654cddd058f419
[05/14] sdn: zones: assign a conntrack zone to zones with a dedicated VRF
       commit: 3f97205d856c180bf826c9dab4e13bc6565882b3




      parent reply	other threads:[~2026-11-20  7:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 19:45 [PATCH docs/manager/network/proxmox{,-ve-rs,-firewall} 00/14] sdn: conntrack zones and SNAT for simple zones with a dedicated VRF Stefan Hanreich
2026-11-19 19:45 ` [PATCH proxmox 01/14] network-api: expose the master device of a link Stefan Hanreich
2026-11-19 19:45 ` [PATCH proxmox-ve-rs 02/14] sdn: config: read the conntrack zone of zones with a dedicated VRF Stefan Hanreich
2026-11-19 19:45 ` [PATCH proxmox-ve-rs 03/14] sdn: conntrack: map the interfaces of zone VRFs to their conntrack zone Stefan Hanreich
2026-11-19 19:45 ` [PATCH pve-network 04/14] sdn: simple: SNAT via the uplinks of zone VRFs Stefan Hanreich
2026-11-19 19:45 ` [PATCH pve-network 05/14] sdn: zones: assign a conntrack zone to zones with a dedicated VRF Stefan Hanreich
2026-11-19 19:45 ` [PATCH proxmox-firewall 06/14] firewall: apply vnet rules to host traffic from vnets in a VRF Stefan Hanreich
2026-11-19 19:45 ` [PATCH proxmox-firewall 07/14] nftables: expression: add a constructor for map lookups Stefan Hanreich
2026-11-19 19:45 ` [PATCH proxmox-firewall 08/14] nftables: statement: add a helper for setting the conntrack zone Stefan Hanreich
2026-11-19 19:45 ` [PATCH proxmox-firewall 09/14] nftables: expression: convert the conntrack zones of zone VRFs Stefan Hanreich
2026-11-19 19:45 ` [PATCH proxmox-firewall 10/14] firewall: add a command applying " Stefan Hanreich
2026-11-19 19:45 ` [PATCH proxmox-firewall 11/14] firewall: put guest traffic of zone VRFs into their conntrack zone Stefan Hanreich
2026-11-19 19:45 ` [PATCH pve-manager 12/14] network: apply the conntrack zones of zone VRFs Stefan Hanreich
2026-11-19 19:45 ` [PATCH pve-manager 13/14] network: warn if pve-firewall cannot isolate guests in " Stefan Hanreich
2026-11-19 19:45 ` [PATCH pve-docs 14/14] pvesdn: simple zones: document dedicated VRFs Stefan Hanreich
2026-11-20  7:42 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179515721910.2281522.2727155874470593742.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.hanreich@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal