From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, "Max R. Carrara" <m.carrara@proxmox.com>
Cc: Alfonso Kuen <gerencia@idkmanager.com>,
Thomas Ellmenreich <t.ellmenreich@proxmox.com>,
Jakob Klocker <j.klocker@proxmox.com>
Subject: applied: [PATCH common/manager/proxmox-widget-toolkit/storage/storage-plugin-examples v5 00/19] GUI Support for Custom Storage Plugins
Date: Mon, 16 Nov 2026 03:20:41 +0100 [thread overview]
Message-ID: <179479559569.3545356.12588016086029581343.b4-ty@b4> (raw)
In-Reply-To: <20261113203330.932813-1-m.carrara@proxmox.com>
On Fri, 13 Nov 2026 21:33:04 +0100, Max R. Carrara wrote:
> GUI Support for Custom Storage Plugins - v5
> ===========================================
>
> This is another refresh based on the feedback on v4 and also some
> off-list discussions. Some additional fixes and little things have also
> been rolled in.
>
> [...]
Applied, thanks!
I folded a few small things in while applying, they are noted in the respective
commits:
- storage 1/9: the plugin list reported the 'origin' filter parameter
as origin of every plugin until 4/9 fixed that, so it was undefined
without a filter.
- storage 3/9: a property in 'sensitive-properties' is now always
reported as sensitive, also if its schema explicitly sets the keyword
to 0. Its value is never returned, so the editor would otherwise
delete it on an unrelated save.
- typos and stale wording in some commit messages (the multiline
"format", checking the Perl module path), a few wide-field xtypes that
could not occur in the editor, and a new subject for the SSHFS patch.
And some follow-ups on top:
- storage: GET /storage and GET /storage/{storage} return 'content-dirs'
as the string that the update call accepts. It was the parsed hash,
which the generated editor showed and sent back as "[object Object]".
- storage: a test for the metadata endpoints and an ApiChangeLog section
for plugin authors. It also spells out that 'multiline' is only a hint
for the editor, the section config still refuses line feeds, and that
a property in 'sensitive-properties' cannot be required.
- widget-toolkit: the base64 text area builds on the new text area
instead of duplicating its submit handling.
- manager: the summary of a storage shows the display name of the
plugin too.
- examples: the Borg plugin got 'multiline' for its SSH key properties,
titles and a display name.
[pve-common] applied to pve-common.git (master)
[1/1] json schema: add multiline validation keyword
https://git.proxmox.com/?p=pve-common.git;a=commitdiff;h=5f147108fb9e6bd9f386f20b745864996a51c8ae
[pve-manager] applied to pve-manager.git (master)
[1/5] api: sort modules and API method registrations
https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=0cef7b9a19ee9b9312c93061a3f7d435b6e50a40
[2/5] ui: storage: remove entry of the removed DRBD plugin
https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=6c26883a83dffc79a71de68e4cd5d85cdc333afb
[3/5] api: add API routes 'plugins' and 'plugins/storage'
https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=37d5cbd176b76d4fa198d9079847c71502402f26
[4/5] ui: storage view: display error when no editor for storage type exists
https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=85332cfe6de6b9409a3ea3c2cf380b98de326fc5
[5/5] ui: storage: add basic UI integration for custom storage plugins
https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=b3781b97ae0aad66b319e41b4918066e0fc4ed06
[proxmox-widget-toolkit] applied to proxmox-widget-toolkit.git (master)
[1/3] form: introduce new 'proxmoxtextarea' field
https://git.proxmox.com/?p=proxmox-widget-toolkit.git;a=commitdiff;h=c391882eeb229e549f8d034bf5002faf47473518
[2/3] utils: introduce helper function getFieldDefFromPropertySchema
https://git.proxmox.com/?p=proxmox-widget-toolkit.git;a=commitdiff;h=940e056f6f390bd2ed50f597f78acaf87c17cb2d
[3/3] acme: use helper to construct ExtJS fields from property schemas
https://git.proxmox.com/?p=proxmox-widget-toolkit.git;a=commitdiff;h=3eca98e87c20001444f8b52618bb9a25c513ae1b
[pve-storage] applied to pve-storage.git (master)
[1/9] api: plugins/storage: add initial routes and endpoints
https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=5f84cec88b4d27af06940c4ed5ef591d723b9e9e
[2/9] api: plugins/storage/plugin: include schema in plugin metadata
https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=d5ab3c5d5d7efa0556ba717238162555ec3eba14
[3/9] api: plugins/storage/plugin: handle sensitive properties in schema
https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=523bda7742b4ec4c8e621c4a901e8c3be255ac17
[4/9] api: plugins/storage/plugin: factor plugin metadata code into helper
https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=f8d0f1c1a472e7a383998d41f863d7509bd49f9d
[5/9] api: plugins/storage/plugin: add plugins' 'content' to their metadata
https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=1d287922800590aab173bbc940877c508b2207fc
[6/9] all plugins: add 'title' to properties, adapt 'description's
https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=4d2f5a31fd749f4e24632083bc7dd3766c73d2db
[7/9] all plugins, api: mark certain properties as advanced in plugindata()
https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=0fe12a447591997902c04f8a04e17dfceb7fe1bd
[8/9] all plugins, api: mark certain properties as hidden in plugindata()
https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=2d2a7031e7b1c273c70a05170f1908aef95abcba
[9/9] api: plugins/storage/plugin: allow plugins to have display names
https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=83e45f5964f5b15e75563103d2b787507ba2eff2
[pve-storage-plugin-examples] applied to pve-storage-plugin-examples.git (master)
[1/1] sshfs: Update SSHFS plugin
https://git.proxmox.com/?p=pve-storage-plugin-examples.git;a=commitdiff;h=861bd66ca7daea21da92870e5301f28a03c1d71f
next prev parent reply other threads:[~2026-11-16 2:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 20:33 [PATCH common/manager/proxmox-widget-toolkit/storage/storage-plugin-examples v5 00/19] GUI Support for Custom Storage Plugins Max R. Carrara
2026-11-13 20:33 ` [PATCH pve-common v5 01/19] json schema: add multiline validation keyword Max R. Carrara
2026-11-13 20:33 ` [PATCH pve-storage v5 02/19] api: plugins/storage: add initial routes and endpoints Max R. Carrara
2026-11-13 20:33 ` [PATCH pve-storage v5 03/19] api: plugins/storage/plugin: include schema in plugin metadata Max R. Carrara
2026-11-13 20:33 ` [PATCH pve-storage v5 04/19] api: plugins/storage/plugin: handle sensitive properties in schema Max R. Carrara
2026-11-13 20:33 ` [PATCH pve-storage v5 05/19] api: plugins/storage/plugin: factor plugin metadata code into helper Max R. Carrara
2026-11-13 20:33 ` [PATCH pve-storage v5 06/19] api: plugins/storage/plugin: add plugins' 'content' to their metadata Max R. Carrara
2026-11-13 20:33 ` [PATCH pve-storage v5 07/19] all plugins: add 'title' to properties, adapt 'description's Max R. Carrara
2026-11-13 20:33 ` [PATCH pve-storage v5 08/19] all plugins, api: mark certain properties as advanced in plugindata() Max R. Carrara
2026-11-13 20:33 ` [PATCH pve-storage v5 09/19] all plugins, api: mark certain properties as hidden " Max R. Carrara
2026-11-13 20:33 ` [PATCH pve-storage v5 10/19] api: plugins/storage/plugin: allow plugins to have display names Max R. Carrara
2026-11-13 20:33 ` [PATCH proxmox-widget-toolkit v5 11/19] form: introduce new 'proxmoxtextarea' field Max R. Carrara
2026-11-13 20:33 ` [PATCH proxmox-widget-toolkit v5 12/19] utils: introduce helper function getFieldDefFromPropertySchema Max R. Carrara
2026-11-13 20:33 ` [PATCH proxmox-widget-toolkit v5 13/19] acme: use helper to construct ExtJS fields from property schemas Max R. Carrara
2026-11-13 20:33 ` [PATCH pve-manager v5 14/19] api: sort modules and API method registrations Max R. Carrara
2026-11-13 20:33 ` [PATCH pve-manager v5 15/19] ui: storage: remove entry of the removed DRBD plugin Max R. Carrara
2026-11-13 20:33 ` [PATCH pve-manager v5 16/19] api: add API routes 'plugins' and 'plugins/storage' Max R. Carrara
2026-11-13 20:33 ` [PATCH pve-manager v5 17/19] ui: storage view: display error when no editor for storage type exists Max R. Carrara
2026-11-13 20:33 ` [PATCH pve-manager v5 18/19] ui: storage: add basic UI integration for custom storage plugins Max R. Carrara
2026-11-13 20:33 ` [PATCH pve-storage-plugin-examples v5 19/19] sshfs: Update SSHFS plugin Max R. Carrara
2026-11-16 2:20 ` Thomas Lamprecht [this message]
2026-11-17 8:07 ` [PATCH common/manager/proxmox-widget-toolkit/storage/storage-plugin-examples v5 00/19] GUI Support for Custom Storage Plugins Roland Kammerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179479559569.3545356.12588016086029581343.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=gerencia@idkmanager.com \
--cc=j.klocker@proxmox.com \
--cc=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.ellmenreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.