From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 1D3B81FF0B7 for ; Fri, 13 Nov 2026 16:28:15 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9785721732; Fri, 13 Nov 2026 16:28:12 +0100 (CET) From: Wolfgang Bumiller To: pve-devel@lists.proxmox.com, Kefu Chai Subject: applied-series: [PATCH common v2 0/2] cmd: run: do not leave the command behind on a caller's timeout Date: Fri, 13 Nov 2026 16:27:58 +0100 Message-ID: <179458367270.315067.12658301359583358416.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261109075938.1737717-1-k.chai@proxmox.com> References: <20261109075938.1737717-1-k.chai@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794583688519 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.321 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 4IX4PLAVZLMQOZAJRF4IK4AWCELA2HSF X-Message-ID-Hash: 4IX4PLAVZLMQOZAJRF4IK4AWCELA2HSF X-MailFrom: w.bumiller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 09 Nov 2026 15:59:36 +0800, Kefu Chai wrote: > a colleague ran 'pvesm alloc' on an RBD pool whose placement groups > never became active: the storage lock gave up and got released, but > 'rbd create' just kept running. Patch 2 kills and reaps the command > after run's eval if it is still around. Patch 1 stops run() from > cancelling the caller's alarm on its way out, which would let > 'lvcreate' run without the lock's limit on shared LVM once 'vgs' ran > before it. > > [...] Applied, thanks! [1/2] cmd: run: do not cancel the caller's alarm commit: e2b5ebd77a4aea76e2dcdeb4776cfc76c08861e0 [2/2] cmd: run: kill the command when run dies commit: a89e2d8195557e741b524c99cd0c33a47bab03c3