From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id A1CB51FF0B7 for ; Fri, 13 Nov 2026 10:31:34 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id A55A521802; Fri, 13 Nov 2026 10:31:07 +0100 (CET) From: Wolfgang Bumiller To: pve-devel@lists.proxmox.com, Hannes Laimer Subject: applied: [PATCH pve-manager] pvescheduler: hold off HUP and CHLD while a child is forked and recorded Date: Fri, 13 Nov 2026 10:30:54 +0100 Message-ID: <179456225103.40281.18315281639873811856.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260915133636.858359-1-h.laimer@proxmox.com> References: <20260915133636.858359-1-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794562262405 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.327 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BPIDBTGLHKB2RYXQOBPBXSVK4LYU4IWW X-Message-ID-Hash: BPIDBTGLHKB2RYXQOBPBXSVK4LYU4IWW X-MailFrom: w.bumiller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 15 Sep 2026 15:36:36 +0200, Hannes Laimer wrote: > A HUP that lands between the fork and recording neither stops nor hands > over that child, since the hand-over string is built in the HUP handler > from what is recorded. A CHLD from a child that exits right after the > fork, before it is recorded, is missed by the reap it triggers and > cleared only at the next CHLD from an unrelated child. > > Hold both signals off until the child is recorded, and once a HUP came > in fork nothing more, since the hand-over is already put together. > > [...] Applied, thanks! [1/1] pvescheduler: hold off HUP and CHLD while a child is forked and recorded commit: d45e600fb36d00a90222f35142a12c3c7f0e8299