From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pbs-devel@lists.proxmox.com, Robert Obkircher <r.obkircher@proxmox.com>
Subject: applied: [PATCH v1 proxmox] router: compare the Fn trait object instead of the ApiHandler address
Date: Wed, 11 Nov 2026 23:37:19 +0100 [thread overview]
Message-ID: <179443663800.1589543.7456834921533733964.b4-ty@b4> (raw)
In-Reply-To: <20260814124206.309661-1-r.obkircher@proxmox.com>
On Fri, 14 Aug 2026 14:40:48 +0200, Robert Obkircher wrote:
> The previous implementation was effectively `ptr::eq(self, rhs)`,
> because it compared the addresses of the fields instead of the trait
> object fat pointers.
>
> This worked anyway, because the tests only compare const values that
> the compiler manages to deduplicate.
>
> [...]
Applied, thanks!
[1/1] router: compare the Fn trait object instead of the ApiHandler address
commit: 9bf4383b6ad4225367c7824023ad74769388de8f
prev parent reply other threads:[~2026-11-11 22:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 12:40 [PATCH v1 proxmox] router: compare the Fn trait object instead of the ApiHandler address Robert Obkircher
2026-11-11 22:37 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179443663800.1589543.7456834921533733964.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=r.obkircher@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.