From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 544351FF0B3 for ; Wed, 11 Nov 2026 23:29:09 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 04AE621621; Wed, 11 Nov 2026 23:29:09 +0100 (CET) From: Thomas Lamprecht To: pbs-devel@lists.proxmox.com, Jakob Klocker Subject: applied: [PATCH proxmox{,-backup} v4 0/5] fix #6990: server: drop verify state on push & pull job Date: Wed, 11 Nov 2026 23:28:36 +0100 Message-ID: <179443477829.1246645.8176092495370125037.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261015121659.239652-1-j.klocker@proxmox.com> References: <20261015121659.239652-1-j.klocker@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794436145994 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.139 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HLNRFJNFAOT3BISFAFIGLFX3GNI3MQOU X-Message-ID-Hash: HLNRFJNFAOT3BISFAFIGLFX3GNI3MQOU X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 15 Oct 2026 14:16:54 +0200, Jakob Klocker wrote: > When syncing a snapshot to another datastore, the source's verify_state > is currently carried over to the target. This reports the target > snapshot as verified even though its stored copy was never checked > there. Since verify jobs skip snapshots that already carry a > verify_state, the target's copy can't be verified again. > > Chunks are checksummed in memory while being transferred, but a verify > serves a different purpose: confirming the write to the (external) > target actually succeeded. > > [...] Applied, thanks! I folded a few changes into patch 4/5, namely: - the target's own verify state is now also dropped when an archive got re-synced, as the old result does not cover the rewritten data - the "nothing changed" fast path compares the manifests ignoring the verify state, as otherwise a verified source could never match its stripped target copy again, so every pull re-hashed all archives and rewrote, and for S3 re-uploaded, the manifest - the manifest is written through the shared replace_file helper [proxmox] applied to git/proxmox.git (master) [1/5] pbs-api-types: implement Hash and Borrow for BackupArchiveName commit: f00b1061ba7e19f620e1ad1f7b0003b4c46d5097 [proxmox-backup] applied to git/proxmox-backup.git (master) [2/5] server: pull: run blocking file operations on the blocking pool commit: b98c63f34d8ccecb78ec8737df9e5b760dc75ff3 [3/5] pbs-datastore: pass expected files to cleanup_unreferenced_files commit: 908ba15753aedb9822bcfed6e217cb1acc9cd1c2 [4/5] fix #6990: server: drop verify state on non-decrypt pull job commit: 7241811f7ed6224fa02294053b0953b9453ed417 [5/5] fix #6990: server: drop verify state on push job commit: bae3060140198d7cdbb3dc37ac08d8356fabf577