all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pbs-devel@lists.proxmox.com, "Max R. Carrara" <m.carrara@proxmox.com>
Subject: applied: [PATCH proxmox v3 0/5] Fix #6738: Improve TLS Handshake Handling & Error Logging
Date: Wed, 11 Nov 2026 23:00:48 +0100	[thread overview]
Message-ID: <179443424575.1210260.12360526617961021704.b4-ty@b4> (raw)
In-Reply-To: <20261110110728.144880-1-m.carrara@proxmox.com>

On Tue, 10 Nov 2026 12:07:22 +0100, Max R. Carrara wrote:
> Fix #6738: Improve TLS Handshake Handling & Error Logging - v3
> ==============================================================
> 
> This is a slightly bigger refresh of an older patch (see below) that
> reduces the noisiness of TLS handshake errors, in particular when health
> checks are only opening and closing connections without sending any
> data.
> 
> [...]

Applied, thanks!

The code was applied as is, I only trimmed some commit messages a tiny bit
while trying hard to keep all relevant info in there.

On top I added a regression test for the case that patch 4/5 fixes,
it provokes the repeated readiness over a real local connection by
filling the server side's send buffer after the client sent two bytes
and letting the client drain it again. It fails deterministically on
the old code and passes with your fix.

[1/5] rest-server: connection: use enum for TLS handshake check result
      commit: f2468d9a1c9419916172c0450466cb110411ceab
[2/5] rest-server: connection: add tests for TLS handshake check
      commit: 2b0e24cb81f289f4840929057318841e6ca07043
[3/5] rest-server: connection: log cause of TLS handshake check errors
      commit: 96e7808d4fac5b3c4d3676a51aab8f2cb8716a87
[4/5] rest-server: connection: avoid dropping clients during TLS check
      commit: b595e9255eefedf7861c8de9ae2500f6b27a5fcd
[5/5] fix #6738: rest-server: log early closed connections at debug level
      commit: 519aecad93f5c881c6aa615b93017bf0daf3fa10




      parent reply	other threads:[~2026-11-11 22:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 11:07 [PATCH proxmox v3 0/5] Fix #6738: Improve TLS Handshake Handling & Error Logging Max R. Carrara
2026-11-10 11:07 ` [PATCH proxmox v3 1/5] rest-server: connection: use enum for TLS handshake check result Max R. Carrara
2026-11-10 11:07 ` [PATCH proxmox v3 2/5] rest-server: connection: add tests for TLS handshake check Max R. Carrara
2026-11-10 11:07 ` [PATCH proxmox v3 3/5] rest-server: connection: log cause of TLS handshake check errors Max R. Carrara
2026-11-10 11:07 ` [PATCH proxmox v3 4/5] rest-server: connection: avoid dropping clients during TLS check Max R. Carrara
2026-11-10 11:07 ` [PATCH proxmox v3 5/5] fix #6738: rest-server: log early closed connections at debug level Max R. Carrara
2026-11-11 22:00 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179443424575.1210260.12360526617961021704.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=m.carrara@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal